From: sashiko-bot@kernel.org
To: "Yuho Choi" <dbgh9129@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v1] PCI: Release SR-IOV device reference on init failure
Date: Fri, 07 Aug 2026 02:24:59 +0000 [thread overview]
Message-ID: <20260807022459.C35251F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260807022025.921764-1-dbgh9129@gmail.com>
> sriov_init() takes a reference on the sibling physical function stored in
> pci_sriov->dev before computing the maximum VF bus usage. If
> compute_max_vf_buses() fails, the failure path clears the SR-IOV state and
> frees pci_sriov without releasing that reference. Since is_physfn is
> cleared, pci_iov_release() cannot clean it up later.
>
> Release the reference on the failure path when pci_sriov->dev is different
> from the device being initialized, matching the cleanup in sriov_release().
>
> Fixes: ea9a8854161d ("PCI: Set SR-IOV NumVFs to zero after enumeration")
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260807022025.921764-1-dbgh9129@gmail.com?part=1
prev parent reply other threads:[~2026-08-07 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 2:20 [PATCH v1] PCI: Release SR-IOV device reference on init failure Yuho Choi
2026-08-07 2:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807022459.C35251F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dbgh9129@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox