Re: [PATCH] PCI: Add quirk for ID mutation of MSI Claw A8 cardreader

[sashiko-bot@kernel.org]

> Derek reports a lockup on resume of the MSI Claw A8 if a card is inserted
> into the onboard Realtek RTS525A cardreader.  He has root-caused it to a
> mutation of the cardreader's Subsystem Vendor and Device ID:  Firmware
> sets an MSI-specific ID on boot, but neglects to reset it on resume.
> The ID thus changes to the generic Realtek Vendor and Device ID.
> 
> The firmware also incorrectly sets the Hot-Plug Capable bit on the Root
> Port and the PCIe hotplug driver interprets the ID mutation as removal of
> the cardreader during system sleep (see pciehp_device_replaced()).
> 
> The lockup is caused by the block layer being unaware of the hot-removal
> and waiting indefinitely in sync_filesystem().  That is fixed with a
> separate commit for the cardreader driver.  However despite that other
> commit, the cardreader is still hot-removed and re-enumerated the first
> time the system is put to sleep.  This is undesirable because it prevents
> [ ... ]
> Reported-by: Derek J. Clark <derekjohn.clark@gmail.com>
> Tested-by: Derek J. Clark <derekjohn.clark@gmail.com>
> Closes: https://lore.kernel.org/r/20260806214808.1202819-1-derekjohn.clark@gmail.com/
> Link: https://github.com/ValveSoftware/SteamOS/issues/2473
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/36578f6e0829bbcdf68659ffad27b65715a97768.1786698126.git.lukas@wunner.de?part=1