From: sashiko-bot@kernel.org
To: "Ruoyu Wang" <ruoyuw560@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: xgene: Fix device node reference leak in xgene_pcie_probe()
Date: Fri, 14 Aug 2026 13:51:12 +0000 [thread overview]
Message-ID: <20260814135112.6F27C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260814134118.1387742-1-ruoyuw560@gmail.com>
> xgene_pcie_probe() takes an extra reference to the platform device's OF
> node and stores it in port->node. The driver never drops the reference,
> so every probe attempt that reaches this point leaks it, including when
> CSR mapping or a later initialization step fails.
>
> The platform device already holds the node reference, and port->node is
> only dereferenced synchronously by xgene_pcie_setup() before probe
> returns. Store the borrowed pointer instead of taking another reference.
>
> This issue was found by a static analysis checker and confirmed by
> manual source review.
>
> Fixes: 5f6b6ccdbe1c ("PCI: xgene: Add APM X-Gene PCIe driver")
> Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260814134118.1387742-1-ruoyuw560@gmail.com?part=1
next prev parent reply other threads:[~2026-08-14 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 13:41 [PATCH] PCI: xgene: Fix device node reference leak in xgene_pcie_probe() Ruoyu Wang
2026-08-14 13:51 ` sashiko-bot [this message]
2026-09-10 12:23 ` Manivannan Sadhasivam
-- strict thread matches above, loose matches on Subject: below --
2026-09-17 13:22 Wentao Liang
2026-09-17 13:29 ` sashiko-bot
2026-09-18 11:50 ` kernel test robot
2026-09-18 12:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814135112.6F27C1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ruoyuw560@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox