Re: [PATCH v4] PCI: imx6: fix resource leaks in probe error paths

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Unbounded resource leak (clocks, regulators, PHYs) during repeated endpoint probe deferrals.
--

--- Patch [1]: [PATCH v4] PCI: imx6: fix resource leaks in probe error paths ---
commit 4146a6183d1b75bd09bf97a22116274151dfc0ca
Author: Zhijian Han <hanzhijian1991@gmail.com>

PCI: imx6: fix resource leaks in probe error paths

This commit addresses resource leaks in the imx6 pcie probe error paths by
introducing imx_pcie_detach_pd() to clean up power domains and pwrctrl
devices. It also adds DL_FLAG_AUTOREMOVE_CONSUMER to device links so they
are cleaned up automatically.

Link: https://lore.kernel.org/all/20260822013640.182C01F000E9@smtp.kernel.org/

> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 39790e66b98dc..0b42093654f04 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c

[ ... ]

> @@ -1956,8 +1974,10 @@ static int imx_pcie_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	ret = pci_pwrctrl_create_devices(dev);
> -	if (ret)
> +	if (ret) {
> +		imx_pcie_detach_pd(imx_pcie);
>  		return dev_err_probe(dev, ret, "failed to create pwrctrl devices\n");
> +	}
>  
>  	pci->use_parent_dt_ranges = true;
>  	if (imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE) {

[Severity: High]
This is a pre-existing issue, but does imx_add_pcie_ep() leak hardware
resources such as clocks, regulators, and PHYs if endpoint initialization
fails or defers?

Looking at imx_add_pcie_ep(), it allocates hardware resources via
imx_pcie_host_init(pp), but if dw_pcie_ep_init(ep) returns an error
(like -EPROBE_DEFER), it returns directly without cleaning them up:

drivers/pci/controller/dwc/pci-imx6.c:imx_add_pcie_ep() {
    ...
	ret = dw_pcie_ep_init(ep);
	if (ret) {
		dev_err(dev, "failed to initialize endpoint\n");
		return ret;
	}
    ...
}

Similarly, if dw_pcie_ep_init_registers(ep) fails, it calls
dw_pcie_ep_deinit(ep) but still misses cleaning up the host resources:

drivers/pci/controller/dwc/pci-imx6.c:imx_add_pcie_ep() {
    ...
	ret = dw_pcie_ep_init_registers(ep);
	if (ret) {
		dev_err(dev, "Failed to initialize DWC endpoint registers\n");
		dw_pcie_ep_deinit(ep);
		return ret;
	}
    ...
}

Should these error paths call imx_pcie_host_exit(pp) to avoid permanently
leaking power and resource references during repeated probe deferrals?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824150454.3511203-1-hanzhijian1991@gmail.com?part=1