Re: [PATCH v2 7/8] hwtracing: hisi_ptt: Add pattern PMU config for trace format selection

[sashiko-bot@kernel.org]

> Introduce a `pattern` PMU config field (config:36-39) that controls
> which TLP header format the hardware traces. bit[3:1] are reserved for
> future extension and only bit0 is used currently:
> 
> - pattern=0 (default, compatibility mode): the driver sets bit[8] of
>   HISI_PTT_TRACE_CTRL so the hardware traces the data in compatibility
>   mode.
> - pattern=1: the driver clears bit[8] of HISI_PTT_TRACE_CTRL so the
>   hardware traces the data pattern including some bitfields of the TLP
>   header defined in PCIe r6.4 sec 2.2.1.2.
> 
> Note that bit[8] of HISI_PTT_TRACE_CTRL is inverted with respect to the
> `pattern` value: bit[8]=1 selects the legacy format, bit[8]=0 selects
> the new format. Bit[11:9] is still reserved, which is consistent with the
> PMU config field. The driver validates the 4-bit value in
> hisi_ptt_trace_valid_pattern() and applies it in hisi_ptt_trace_start().
> 
> Document the new parameter in Documentation/trace/hisi-ptt.rst.
> 
> Signed-off-by: Sizhe Liu <liusizhe5@huawei.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827140442.2031128-1-liusizhe5@huawei.com?part=7