Re: [PATCH 1/3] PCI: endpoint: Support hardware-owned MSI-X table and PBA

[sashiko-bot@kernel.org]

> Some endpoint controllers expose the MSI-X table and Pending Bit Array
> (PBA) in fixed, hardware-owned BAR regions. The EPC set_msix() callback
> currently receives only the table BAR and offset and assumes that the PBA
> immediately follows the table in the same BAR. It cannot describe a fixed
> layout whose table and PBA have independent locations.
> 
> Add struct pci_epc_msix_layout and pass the full layout to
> pci_epc_set_msix(). Leave layout selection to EPF implementations. For
> instance, pci-epf-ntb reads the MSI-X Table from its own BAR. Using a
> fixed layout there would require a way to read hardware-owned Table
> entries. Add pci_epc_get_hw_msix_layout() for EPFs that want the fixed
> layout. Update the existing callers and validate the supplied layout.
> 
> Signed-off-by: Koichiro Den <den@valinux.co.jp>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827182012.1984960-1-den@valinux.co.jp?part=1