Re: [PATCH v3 4/4] of: address: kill of_node_is_pcie()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Outdated comment in `of_bus_pci_match()` incorrectly claims a warning is issued.
--

commit 0ffaade5a7eebd20cc4d79d7c8ed0d49f6da1857
Author: Alex Elder <elder@riscstar.com>

of: address: kill of_node_is_pcie()

The of_bus->match function for the "PCI" bus type is fairly liberal
in what it accepts as a PCI bus devicetree node.  If a node has no
device_type property, it even allows a node named "pcie@" to be
accepted as represnting a devicetree bus, though it issues a warning
in that case.

> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 499d37ceae210..ee2eb44884d85 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c

[ ... ]

> @@ -156,7 +146,7 @@ static int of_bus_pci_match(struct device_node *np)
>  	 * "ht" is hypertransport
>  	 *
>  	 * If none of the device_type match, and that the node name is
>  	 * "pcie", accept the device as PCI (with a warning).
>  	 */
>  	return of_node_is_type(np, "pci") || of_node_is_type(np, "pciex") ||
>  		of_node_is_type(np, "vci") || of_node_is_type(np, "ht") ||
> -		of_node_is_pcie(np);
> +		of_node_name_eq(np, "pcie");
>  }

[Severity: Low]
Does the comment block above this return statement need to be updated?

Since the patch replaces the call to of_node_is_pcie() with a direct check
of the node name to avoid duplicate warnings, the comment in of_bus_pci_match()
claiming that it accepts the device "(with a warning)" seems to be a minor
documentation regression.

Could we update the comment to reflect the new behavior?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901011338.1323243-1-elder@riscstar.com?part=4