Re: [PATCH v4 13/16] gpu: nova-core: convert hshub0 from relative register to projection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Nested imports are not formatted using the kernel vertical import style.
--

commit 5f257dd4b3d5392812ee98a7773fef681ee000af
Author: Gary Guo <gary@garyguo.net>

gpu: nova-core: convert hshub0 from relative register to projection

This commit converts the hshub0 relative access to use a projection and a
new base register. This brings it in line with the earlier PFALCON and
PFALCON2 conversions.

[ ... ]

> diff --git a/drivers/gpu/nova-core/fb/regs.rs b/drivers/gpu/nova-core/fb/regs.rs
> index c27582e376e29..abb48b0955a9e 100644
> --- a/drivers/gpu/nova-core/fb/regs.rs
> +++ b/drivers/gpu/nova-core/fb/regs.rs
> @@ -2,7 +2,8 @@
>  
>  use kernel::{
>      io::register,
> -    sizes::SizeConstants, //
> +    prelude::*,
> +    sizes::{SizeConstants, SZ_4K}, //

[Severity: Low]
This isn't a bug, but should these nested imports be formatted using the
kernel vertical import style? 

The Rust coding guidelines generally require breaking nested imports
vertically into multiple lines rather than keeping them grouped on a single
line like sizes::{SizeConstants, SZ_4K} in the imports block of regs.rs.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-typed_register-v4-0-5552b1d59525@garyguo.net?part=13