From: sashiko-bot@kernel.org
To: "Sizhe Liu" <liusizhe5@huawei.com>
Cc: linux-perf-users@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 6/8] perf hisi-ptt: Add field-level parsing for header DW2/DW3
Date: Thu, 03 Sep 2026 08:08:42 +0000 [thread overview]
Message-ID: <20260903080842.A5A431F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903075241.1445338-7-liusizhe5@huawei.com>
> Add field-level parsing of Header DW2 and DW3 of the TLP, separating
> the layout for CFG TLPs and CPL TLPs. The message type parsed in the
> previous patch is used to select the correct field layout.
>
> DW2 fields are common to MWr/Msg/MsgD/FetchAdd/Swap/CAS/IORd/IOWr
> TLPs, parsed with FIELD_GET() against HISI_PTT_HEAD2_* masks.
>
> DW3 fields have two layouts:
> - CfgRd0/CfgWr0/CfgRd1/CfgWr1 use HISI_PTT_HEAD3_CFG_* masks
> - Cpl/CplD/CplLk/CplDlk use HISI_PTT_HEAD3_CPL_* masks
>
> HiSilicon PCIe trace device hardware is responsible for packet collection,
> parsing, extraction and fills the corresponding fields with the required
> positions. The packet decoder software will perform the parsing and
> printing of fields filled by hardware.
>
> Reviewed-by: Yushan Wang <wangyushan12@huawei.com>
> Signed-off-by: Sizhe Liu <liusizhe5@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903075241.1445338-1-liusizhe5@huawei.com?part=6
next prev parent reply other threads:[~2026-09-03 8:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:52 [PATCH v3 0/8] Enhance TLP packet decoder with field-level parsing and versioning Sizhe Liu
2026-09-03 7:52 ` [PATCH v3 1/8] perf hisi-ptt: Abstract trace data buf and offset Sizhe Liu
2026-09-03 7:59 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 2/8] perf hisi-ptt: Complete the field names for 4DW and 8DW packets Sizhe Liu
2026-09-03 7:57 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 3/8] perf hisi-ptt: Extract the raw data printing part Sizhe Liu
2026-09-03 8:00 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 4/8] perf hisi-ptt: Merge 4DW and 8DW HEAD0 printing Sizhe Liu
2026-09-03 8:03 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 5/8] perf hisi-ptt: Add parsing of supported message types Sizhe Liu
2026-09-03 8:07 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 6/8] perf hisi-ptt: Add field-level parsing for header DW2/DW3 Sizhe Liu
2026-09-03 8:08 ` sashiko-bot [this message]
2026-09-03 7:52 ` [PATCH v3 7/8] hwtracing: hisi_ptt: Add pattern PMU config for trace format selection Sizhe Liu
2026-09-03 8:17 ` sashiko-bot
2026-09-03 7:52 ` [PATCH v3 8/8] perf hisi-ptt: Pass pattern version to decoder for compatibility Sizhe Liu
2026-09-03 8:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903080842.A5A431F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liusizhe5@huawei.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox