From: Peixin Xie <peixin.xie@linux.spacemit.com>
To: rafael@kernel.org
Cc: andriy.shevchenko@linux.intel.com, hansg@kernel.org,
helgaas@kernel.org, ilpo.jarvinen@linux.intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
lukas@wunner.de, mika.westerberg@linux.intel.com,
peixin.xie@linux.spacemit.com, sakari.ailus@linux.intel.com
Subject: Re: [PATCH v3 0/4] ACPI: scan: Adjust power management initialization and PCI devices handling
Date: Fri, 4 Sep 2026 17:40:30 +0800 [thread overview]
Message-ID: <20260904094030.2455645-1-peixin.xie@linux.spacemit.com> (raw)
In-Reply-To: <6044499.DvuYhMxLoT@rafael.j.wysocki>
Hi Rafael,
On Thu, 03 Sep 2026 18:57:09 +0200, Rafael J. Wysocki wrote:
> Hi All,
>
> This is an update of
>
> https://lore.kernel.org/linux-acpi/5144065.31r3eYUQgx@rafael.j.wysocki/
>
> that adds 1 patch, 3 two patches, and addresses review comments in patch [2/4].
>
> The new patch drops in v3 is a cleanup relocating the acpi_bus_init_power()
> declaration to an internal header file in the core ACPI support code (patch
> [3/4]).
>
> One of the patches dropped from the v2 has been folded into patch [2/4]
> and the other two have become cleanups on top of this series that can be
> done later.
>
> Overall, the series aims at addressing a few issues present in the core ACPI
> device enumeration code, mostly related to the acpi_bus_attach() function.
>
> The first one is that, on some systems, ACPI power management is initialized
> twice for devices that have missing dependencies to start with. An attempt
> to address this issue had been made during the 7.3 merge window, but it had
> to be reverted [1]. The approach used here is roughly the same as in the
> reverted commit, but it takes PCI devices (which are a special case) into
> account.
>
> In addition to the above, ACPI power management may be initialized prematurely
> for device objects whose parents are not ready for enumeration.
>
> The other issues are that flags are unnecessarily cleared by acpi_bus_attach()
> for devices with missing dependencies and PCI devices are handled by
> acpi_bus_attach() like any other devices which is a mistake.
>
> Please see the changelogs of individual patches for details.
>
> Thanks!
>
>
> Link: https://lore.kernel.org/linux-acpi/20260820-acpi-power-resource-ref-fix-v2-1-29818173ea13@linux.spacemit.com/ [1]
I tested the complete v3 series on the SpacemiT K3 RISC-V Pico-ITX platform
where the original duplicate ACPI PowerResource reference issue was
observed.
The power resource left on by firmware is now turned off as unused after
the namespace scan. After the device dependency is satisfied, the power
resource is turned on once for the device and is turned off normally
during runtime suspend. Runtime resume also works correctly.
Tested-by: Peixin Xie <peixin.xie@linux.spacemit.com>
--
Best Regards,
Peixin Xie
next prev parent reply other threads:[~2026-09-04 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 16:57 [PATCH v3 0/4] ACPI: scan: Adjust power management initialization and PCI devices handling Rafael J. Wysocki
2026-09-03 16:58 ` [PATCH v3 1/4] ACPI: PM: Drop parent state update from acpi_device_get_power() Rafael J. Wysocki
2026-09-03 17:19 ` sashiko-bot
2026-09-03 17:05 ` [PATCH v3 2/4] ACPI: scan: Stop calling acpi_bus_init_power() early Rafael J. Wysocki
2026-09-03 17:24 ` sashiko-bot
2026-09-03 17:06 ` [PATCH v3 3/4] ACPI: PM: Move acpi_bus_init_power() declaration to internal header file Rafael J. Wysocki
2026-09-03 17:13 ` sashiko-bot
2026-09-03 17:09 ` [PATCH v3 4/4] ACPI: scan: Combine two conditionals in acpi_bus_attach() Rafael J. Wysocki
2026-09-03 17:13 ` sashiko-bot
2026-09-04 9:40 ` Peixin Xie [this message]
2026-09-04 10:04 ` [PATCH v3 0/4] ACPI: scan: Adjust power management initialization and PCI devices handling Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904094030.2455645-1-peixin.xie@linux.spacemit.com \
--to=peixin.xie@linux.spacemit.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hansg@kernel.org \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox