Re: [PATCH 05/13] ARM: orion/dove/mv78xx0: remove all board files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Orphaned MAINTAINERS entry for the TS-78xx platform.
- [Low] Legacy IRQ, MPP, and GPIO implementations are now unreachable dead code and unnecessarily compiled.
--

commit 67c50c71bc1677d3a7c7538373463163afb7b062
Author: Arnd Bergmann <arnd@arndb.de>
Subject: ARM: orion/dove/mv78xx0: remove all board files

This commit removes the legacy board files for the Orion, Dove, and MV78xx0 
platforms. These files were retained in 2022 due to support in Debian/OpenWRT, 
which is now gone.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index fdd75b73bf293..2bb036e8ddcd9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3080,8 +3080,6 @@ F:	Documentation/devicetree/bindings/arm/marvell/marvell,orion5x.yaml
>  F:	Documentation/devicetree/bindings/soc/dove/
>  F:	arch/arm/boot/dts/marvell/dove*
>  F:	arch/arm/boot/dts/marvell/orion5x*
> -F:	arch/arm/mach-dove/
> -F:	arch/arm/mach-mv78xx0/
>  F:	arch/arm/mach-orion5x/
>  F:	arch/arm/plat-orion/
>  F:	drivers/bus/mvebu-mbus.c

[Severity: Low]
Since all the board files like arch/arm/mach-orion5x/ts78xx-setup.c are
removed in this patch, should the MAINTAINERS entry for the TS-78xx platform
further down in this file also be removed?

The pattern F: arch/arm/mach-orion5x/ts78xx-* now points to deleted files,
which leaves an orphaned entry for Alexander Clouter.

[ ... ]

> diff --git a/arch/arm/mach-orion5x/Makefile b/arch/arm/mach-orion5x/Makefile
> index 6f54d7fef27a7..7e9634e043185 100644
> --- a/arch/arm/mach-orion5x/Makefile
> +++ b/arch/arm/mach-orion5x/Makefile
> @@ -2,15 +2,6 @@
>  ccflags-y := -I$(srctree)/arch/arm/plat-orion/include
>  
>  obj-y				+= common.o pci.o irq.o mpp.o
> -obj-$(CONFIG_MACH_KUROBOX_PRO)	+= kurobox_pro-setup.o
> -obj-$(CONFIG_MACH_TERASTATION_PRO2)	+= terastation_pro2-setup.o

[Severity: Low]
Are irq.o and mpp.o now completely unreachable code?

Since all the board files that called into these APIs have been removed,
it appears these objects are now unnecessarily compiled into the kernel
image. Should they be removed from obj-y here?

[ ... ]

> diff --git a/arch/arm/plat-orion/Makefile b/arch/arm/plat-orion/Makefile
> index e8c7580df8caf..dfde39cdd992b 100644
> --- a/arch/arm/plat-orion/Makefile
> +++ b/arch/arm/plat-orion/Makefile
> @@ -5,5 +5,5 @@
>  ccflags-y := -I$(src)/include
>  
>  orion-gpio-$(CONFIG_GPIOLIB)      += gpio.o
> -obj-$(CONFIG_PLAT_ORION_LEGACY)   += irq.o pcie.o time.o common.o mpp.o
> +obj-$(CONFIG_PLAT_ORION_LEGACY)   += irq.o pcie.o mpp.o
>  obj-$(CONFIG_PLAT_ORION_LEGACY)   += $(orion-gpio-y)

[Severity: Low]
Similarly, does this leave irq.o, mpp.o, and the orion-gpio-y objects as dead
code as well?

Since their corresponding entry points in the board files were deleted,
could these also be removed from the build?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908152808.3928630-1-arnd@kernel.org?part=5