Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Logan Odell" <loganodell@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/IOV: Make VF config reads match PCIe 7.0 spec
Date: Thu, 10 Sep 2026 17:50:29 +0000	[thread overview]
Message-ID: <20260910175029.B9C8D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910173648.1304517-1-loganodell@google.com>

> The revision and subsystem ID of the VFs for a given PF do not all have
> to match per 7.5.1.1.5 and 7.5.1.2.3[1]. Read these values from the
> config space instead of using cached values from VF0. Class codes and
> subsystem vendor IDs do need to match per 7.5.1.1.6 and 7.5.1.2.3. Use
> the PF's value instead of reading from the VF config space. Per
> 7.5.1.1.9, the header type for a VF should be 0, so hardcode that
> assignment.
> 
> [1] https://members.pcisig.com/wg/PCI-SIG/document/previewpdf/22464
> 
> Fixes: cf0921bea66c ("PCI/IOV: Use VF0 cached config registers for other VFs")
> Signed-off-by: Logan Odell <loganodell@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910173648.1304517-1-loganodell@google.com?part=1


      reply	other threads:[~2026-09-10 17:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 17:36 [PATCH] PCI/IOV: Make VF config reads match PCIe 7.0 spec Logan Odell
2026-09-10 17:50 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910175029.B9C8D1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=loganodell@google.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox