Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/PCI: Fix device reference leak in pirq_find_router()
Date: Tue, 15 Sep 2026 07:08:48 +0000	[thread overview]
Message-ID: <20260915070849.1A59E1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260915070310.1733310-1-vulab@iscas.ac.cn>

> pci_get_domain_bus_and_slot() takes a reference on the router device
> looked up from the routing table. If the device is found but no router
> handler probes it successfully, the reference is neither stored in
> pirq_router_dev nor dropped. Put the device reference when the router
> probe fails.
> 
> Fixes: ac7cd5e16df8 ("x86/PCI: Handle PIRQ routing tables with no router device given")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915070310.1733310-1-vulab@iscas.ac.cn?part=1


      reply	other threads:[~2026-09-15  7:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  7:03 [PATCH] x86/PCI: Fix device reference leak in pirq_find_router() Wentao Liang
2026-09-15  7:08 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915070849.1A59E1F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox