From: sashiko-bot@kernel.org
To: "Michal Clapinski" <mclapinski@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/DOE: Poll briefly for a response before sleeping
Date: Thu, 17 Sep 2026 23:10:18 +0000 [thread overview]
Message-ID: <20260917231019.3EA121F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260917230323.3701743-1-mclapinski@google.com>
> doe_statemachine_work() waits for a response by sleeping
> PCI_DOE_POLL_INTERVAL (PCI_DOE_TIMEOUT / 128) between status reads,
> which is 7 ms at HZ=1000 and 4 ms at HZ=250. Exchanges are served from
> the device's local mailbox logic and typically complete within tens of
> microseconds, so nearly all of that sleep is wasted. Every DOE-capable
> endpoint pays it once per supported feature during enumeration.
>
> Poll with usleep_range(20, 50) for the first ~2 ms before falling back
> to the jiffies-based wait. On an Intel Emerald Rapids system, time spent
> in pci_device_add() for a DOE-capable endpoint drops from 41.8 ms to
> 14.0 ms.
>
> Signed-off-by: Michal Clapinski <mclapinski@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917230323.3701743-1-mclapinski@google.com?part=1
next prev parent reply other threads:[~2026-09-17 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 23:03 [PATCH] PCI/DOE: Poll briefly for a response before sleeping Michal Clapinski
2026-09-17 23:10 ` sashiko-bot [this message]
2026-09-18 14:27 ` Lukas Wunner
2026-09-18 19:28 ` Michał Cłapiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917231019.3EA121F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mclapinski@google.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox