From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F96515967 for ; Fri, 18 Sep 2026 17:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; cv=none; b=imYnEnX76xhEX7lhIX4PQmL8Loz6+mEiQG9sjRKFw7DmYsxK4ZfLoqSnQYInx/mcCEc2Cx3w7/7eUb1w7vEymZkb4sAhe5Qd0ZrZWJMzKRssR/GjFbfWv2cZZDoLyyfu9gGWA8RCc349wwma4hZ2qEQzWlBP2smQ3/bK8uLFV1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789751131; c=relaxed/simple; bh=CJUtrnr9lbLTqP4H/g58GCIz+hH13m2n3S92AYR7A28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HFSkWnlwdTv5hMPexadgCfhuSVYxrI5RSAb+Slgg4Twx9VNYUjIq5tb+z1k0mVYnpj3lGQs65HHm++ZTvhXDlr79CcNPuzbD5IGEfDZSGfIfZt+yJT09RsSeHXDPXTHbdX4x6blbVIfQNkdQ70KUwb2mmqqWJxzw7Pf+lCJ0Aw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Zz16yMCv; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Zz16yMCv" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-90cdfc9b6ebso8840556d6.2 for ; Fri, 18 Sep 2026 10:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1789751128; x=1790355928; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=Zz16yMCvY0iYXnp4qSVkoFqfYheoD9f4m4mpImDpG1lBK5zjAXrDhEED+ZfgtMmKKb jys1jwEN8feW5ojbOVgRO7XgWW2iy67XVyUkEePMk5Xq6LEVrQtxqWBns2aRZejZ6kJU HZ3uRkD5CDOL6CSN2PRfm2xk3H9ERs6jPpBH6GG1MSBQXYB+kTGNA7u/HWhSBwG7Z8Zc 1GA+sGz6DLtPsTxDCzbUGJ/rXGjWsZvqLvGOJl6akUaZJu/X9tM8vqjyN91+zujqQvdc QgrytW/wV/mz66H73GTtDWEYG7ooveG8Pea/yxI0TY3AjvDlYVkLOtJPGvN28tqX534d oQLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789751128; x=1790355928; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zQcyEtFjPBr6Six+ddaDb/CoGlSZSKi7ev20pm6BxlM=; b=nUsaoxBL1pnTjkKB5wwIt0+aWODhZPImUZB2NqT4LzBTIfEuo5hwZK3oivs9Shvq/i +psRC5X74xnVAjrct/dWKHQXfpn0N8c91nXXPogV6o/Y5Nbj1KO3veDq6c5ob9exjmVg 19r9rRT5R9Td+4YrOsOu+3N3A9P8lTp5Dwo1UE0Lx6CpB5S89q+lAGp/9NVTx1oi+2oz 9wqYplQfV8684oUBWgChVoUXytYNI7Jj7WathdOCa0yBt6HC2WID7jGtHas07KOUqsv+ qy629ZuIibASrMThk2etSxu4VnWfzxXSLyBx0gxa/obCDLCHJabhinT4SIgJ9PhftNOm rIyA== X-Forwarded-Encrypted: i=1; AKwUvByeMPhJgVk0ThMDnkpVwu0u8b3mzVHHnAgpvrWRXD7PLaQ6nCgtSOWU5+S5Xp5Ku+XOXZs+WPhUskQ=@vger.kernel.org X-Gm-Message-State: AFuF++lp4BIcdmzJ3PLYGtpgLYYo2jR8YA8nBTNBeWcXbT0nQDXzpvwg jeDWLYLwLin1CwPaHtRUh05PsXjnUf9UEdi99f/pDoXZL1SjADQdcKSbeVg09hzE1bY= X-Gm-Gg: AYBFou2Shq65054KeDlFdeoTkj+7WewL7H8mIlkVm32KplZUqeoEKujDSi/wJle23Yo Ws5HcfsUYQT1WExQDljNcvm+t+H3Kt2bofqISB01y+EUEve9sWlbeey4CaHgI4KmGfzJo0nAqBD wBwLpguSJwef1m0SgbvFNqVDLmIs6J4ODKM6YobC/J/NCTyDtLBhHOv9XZSF8nzim0LgTxh6fEh hfiEY5I270g67zdJEAMPvE8uZxnZmFtmSQ3kiYTE7lBpS3RqrGCwhteBnfjATv9eKAIaD+PJI2D uOcL/wZFa+ygupuI4T1lBEMlfZtmd2lsbeot7kC9UofotiLtE4WaDiVuNpdHWi5GclZDane9Tmm GSsJDT5EgWCxZc0/szwBbLghcqudIK5g8+nduFg2b3qdjGS6M1+pHERhrzgyGokWZcFChSd0mv5 fHbtDQOQFULl5YGc4qwr42mnCO/TBKfKhnw4afVWblJcdFVhR92gTrokBe4+as9ZQvuUpqN36pH 3PDtQR+vu3hh3HKzoQh47Uv78F/Pz7zd9/uA+Q3Yb56iF0Me2Q2A+UX X-Received: by 2002:a05:620a:440d:b0:93a:83d:1d26 with SMTP id af79cd13be357-93bdc6c7741mr490404585a.32.1789751128040; Fri, 18 Sep 2026 10:05:28 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93be0cc67e6sm187224885a.5.2026.09.18.10.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 10:05:25 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1x7c1c-00000001zVZ-3Nwz; Fri, 18 Sep 2026 14:05:24 -0300 Date: Fri, 18 Sep 2026 14:05:24 -0300 From: Jason Gunthorpe To: Thomas =?utf-8?Q?Hellstr=C3=B6m?= Cc: Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Chaitanya Kulkarni , Greg Kroah-Hartman , Jens Axboe , Alex Williamson , Ankit Agrawal , Jonathan Corbet , Shuah Khan , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Randy Dunlap , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux.dev, Tushar Dave , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v6 18/18] RDMA/mlx5: Ask P2PDMA whether ATS takes a direct peer-to-peer route Message-ID: <20260918170524.GH11599@ziepe.ca> References: <20260914-fix-p2p-acs-v4-0-v6-0-5ef07ec9ef06@nvidia.com> <20260914-fix-p2p-acs-v4-0-v6-18-5ef07ec9ef06@nvidia.com> <321890690ce83d1943b2f678bd9bee9b8c895b66.camel@linux.intel.com> <20260918121500.GV13683@unreal> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 18, 2026 at 03:42:28PM +0200, Thomas Hellström wrote: > > 1) Xe attachment check if pci_p2pdma_distance() returns OK for the > path. Then Xe always sets up dma-addresses using dma_map_resource(). Open coding pci_p2pdma_distance() in drivers is a hack. Using dma_map_resource() like this was never "allowed". We've fixed things so these hacks are not needed, the drivers need to move over to things like dma_buf_phys_vec_to_sgt() and the hmm helpers to use the DMA API correctly. > 1a) Let's say the importer (Xe) has ATS enabled, and the exporter is > supposed to map dma_addresses. > In between there is a switch that allows direct traffic. > Now with your patch series, How would the exporter know that Xe has ATS > enabled and therefore should return IOVA mappings rather than the BUS > addresses representing the shortcut. The thing that does the DMA map must be aware of what PCI TLPs the PCIe initiator will use to compute the proper P2P mapping mode. ATS always needs an IOVA but that still doesn't mean the P2P will work. > It seems to me that a pci-device settable flag "ATS always enabled" > should be enough to fix both issues? It should be be per-mapping to support the NIC workflow that isn't a global operation. Jason