Re: [PATCH v2] PCI/AER: Fix struct pci_dev reference leak in aer_process_err_devices()

[sashiko-bot@kernel.org]

> When an AER error occurs, candidate error-source devices are added to
> e_info->dev[] by add_error_device(), which takes a reference with
> pci_dev_get().
> 
> A device can be recorded without any error status being present: the
> Requester ID fast path in is_error_source(),
> 
> 	if (e_info->id == pci_dev_id(dev))
> 		return true;
> 
> matches purely on the ID reported by the Root Port and returns true
> without reading the device's AER status registers.
> 
> In aer_process_err_devices(), handle_error_source() is called only if
> aer_get_device_error_info() returns non-zero, i.e. only if an unmasked
> [ ... ]
> handle_error_source() is static and aer_process_err_devices() is its only
> caller, so no other path is affected.
> 
> Fixes: 60271ab044a5 ("PCI/AER: Take reference on error devices")
> Signed-off-by: Priyank Rathod <rathodpriyank@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-fix-aer-refcount-leak-v2-1-bdd1ff1c35a9@google.com?part=1