From: sashiko-bot@kernel.org
To: "Pengpeng Hou" <hppiscas@163.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: eswin: Publish the platform driver OF alias
Date: Sun, 20 Sep 2026 03:45:36 +0000 [thread overview]
Message-ID: <20260920034536.618561F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260920033737.13957-1-hppiscas@163.com>
> PCIE_ESWIN is tristate and eswin_pcie_driver uses an OF match table, but
> the table is not exported. The resulting module lacks the OF alias
> needed for automatic loading on an ESWIN PCIe host controller.
>
> Export the OF table. Keep builtin_platform_driver() and the intentional
> absence of an unregister path unchanged; module alias publication does
> not require making this interrupt-controller driver unloadable.
>
> The issue was found by our static-analysis tool.
>
> Fixes: b593c26d081a ("PCI: eswin: Add ESWIN PCIe Root Complex driver")
> Assisted-by: gpt 5
> Signed-off-by: Pengpeng Hou <hppiscas@163.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920033737.13957-1-hppiscas@163.com?part=1
prev parent reply other threads:[~2026-09-20 3:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 3:37 [PATCH v2] PCI: eswin: Publish the platform driver OF alias Pengpeng Hou
2026-09-20 3:45 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920034536.618561F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hppiscas@163.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox