From: sashiko-bot@kernel.org
To: "Runyu Xiao" <runyu.xiao@seu.edu.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Make poll mode parameter read-only
Date: Mon, 21 Sep 2026 14:34:03 +0000 [thread overview]
Message-ID: <20260921143403.994C11F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260921142608.270312-1-runyu.xiao@seu.edu.cn>
> pciehp_request_irq() and pciehp_free_irq() select different resources
> based on the global pciehp_poll_mode parameter. The parameter is
> currently writable through sysfs, so changing it while a controller is
> active can make teardown stop a nonexistent polling thread or call
> free_irq() for an IRQ that was not requested.
>
> Keep the parameter available for boot and module configuration, but
> prevent runtime changes to the registration mode.
>
> Reproducer:
> Boot an x86_64 guest in QEMU with a native PCIe hotplug root port and an
> e1000 device, using these device options:
>
> -device pcie-root-port,id=rp1,chassis=1,slot=1
> -device e1000,bus=rp1
> [ ... ]
>
> Fixes: 2aeeef119995 ("pciehp: Clean up pcie_init()")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM Codex
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921142608.270312-1-runyu.xiao@seu.edu.cn?part=1
next prev parent reply other threads:[~2026-09-21 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 14:26 [PATCH] PCI: pciehp: Make poll mode parameter read-only Runyu Xiao
2026-09-21 14:34 ` sashiko-bot [this message]
2026-09-21 15:41 ` Lukas Wunner
2026-09-21 17:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921143403.994C11F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox