From: sashiko-bot@kernel.org
To: "Naman Jain" <namjain@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 3/4] x86/irq: Use irq_chip_retrigger_hierarchy() in msi_set_affinity()
Date: Wed, 23 Sep 2026 04:42:22 +0000 [thread overview]
Message-ID: <20260923044222.C9B9A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923043023.3150498-4-namjain@linux.microsoft.com>
> The irqchips used by msi_set_affinity() are initialized by
> x86_init_dev_msi_info(), which sets their irq_retrigger() callback to
> irq_chip_retrigger_hierarchy(). Call the hierarchy helper directly instead
> of invoking it indirectly through the irqchip callback.
>
> Suggested-by: Thomas Gleixner <tglx@kernel.org>
> Reviewed-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Reviewed-by: Thomas Gleixner <tglx@kernel.org>
> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923043023.3150498-1-namjain@linux.microsoft.com?part=3
next prev parent reply other threads:[~2026-09-23 4:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 4:30 [PATCH v6 0/4] x86/irq: Fix lost interrupts on CPU hot-unplug Naman Jain
2026-09-23 4:30 ` [PATCH v6 1/4] x86/hyperv: Set irq_retrigger for root partition PCI/MSI irqchip Naman Jain
2026-09-23 4:37 ` sashiko-bot
2026-09-23 4:30 ` [PATCH v6 2/4] x86/irq: Use irq_chip_retrigger_hierarchy() in fixup_irqs() Naman Jain
2026-09-23 4:41 ` sashiko-bot
2026-09-23 4:30 ` [PATCH v6 3/4] x86/irq: Use irq_chip_retrigger_hierarchy() in msi_set_affinity() Naman Jain
2026-09-23 4:42 ` sashiko-bot [this message]
2026-09-23 14:30 ` Michael Kelley
2026-09-23 4:30 ` [PATCH v6 4/4] x86/irq, iommu/amd, x86/hyperv, PCI: Drop redundant irq_retrigger inits Naman Jain
2026-09-23 4:43 ` sashiko-bot
2026-09-23 14:33 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923044222.C9B9A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=namjain@linux.microsoft.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox