From: sashiko-bot@kernel.org
To: "Abhin Parekadan Jose" <abhinjoses@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC v4 2/5] PCI: pciehp: Add pci_hp_wait_link_change()
Date: Sun, 27 Sep 2026 18:26:57 +0000 [thread overview]
Message-ID: <20260927182658.2C8951F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927182017.938565-3-abhinjoses@gmail.com>
> pci_hp_spurious_link_change() awaits the end of a code section causing
> spurious link changes, such as a Secondary Bus Reset, and then tells
> whether such a section has executed, using test_and_clear_bit() on
> PCI_LINK_CHANGED. The answer is one-shot: only the first caller sees
> true.
>
> Split the wait out into pci_hp_wait_link_change(), which leaves
> PCI_LINK_CHANGED alone, and implement pci_hp_spurious_link_change() on
> top of it. Test PCI_LINK_CHANGING with test_bit_acquire(), so that the
> caller's subsequent accesses are ordered after the end of the code
> section even if wait_event() returns without sleeping. No functional
> change intended.
>
> Signed-off-by: Abhin Parekadan Jose <abhinjoses@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927182017.938565-1-abhinjoses@gmail.com?part=2
next prev parent reply other threads:[~2026-09-27 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 18:20 [PATCH RFC v4 0/5] PCI: pciehp: Report surprise removal during safe removal Abhin Parekadan Jose
2026-09-27 18:20 ` [PATCH RFC v4 1/5] PCI: Report surprise removal event Abhin Parekadan Jose
2026-09-27 18:31 ` sashiko-bot
2026-09-27 18:20 ` [PATCH RFC v4 2/5] PCI: pciehp: Add pci_hp_wait_link_change() Abhin Parekadan Jose
2026-09-27 18:26 ` sashiko-bot [this message]
2026-09-27 18:20 ` [PATCH RFC v4 3/5] PCI/DPC: Add pci_dpc_wait_recovery() Abhin Parekadan Jose
2026-09-27 18:24 ` sashiko-bot
2026-09-27 18:20 ` [PATCH RFC v4 4/5] PCI: pciehp: Report surprise removal from pciehp_isr() Abhin Parekadan Jose
2026-09-27 18:28 ` sashiko-bot
2026-09-27 18:20 ` [PATCH RFC v4 5/5] misc: Add edu_srpoc surprise removal POC driver Abhin Parekadan Jose
2026-09-27 18:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927182658.2C8951F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abhinjoses@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox