Re: [PATCH v5 1/3] PCI/AER: Fix memory leak in aer_recover_queue() on kfifo buffer overflow

[sashiko-bot@kernel.org]

> When ACPI APEI/GHES processes PCIe AER error records, it allocates memory
> for aer_capability_regs (aer_regs) from ghes_estatus_pool and passes it
> to aer_recover_queue() to be enqueued into aer_recover_ring.
> 
> If kfifo_in_spinlocked() fails due to a buffer overflow,
> aer_recover_queue() logged an error message but returned without freeing
> aer_regs. Because the entry was rejected and never inserted into the
> queue, aer_recover_work_func() could never dequeue or free it, leaking
> the allocated ghes_estatus_pool memory.
> 
> aer_recover_queue() returns void, so the caller ghes_handle_aer() cannot
> free the buffer itself: ownership is transferred to the AER code, which
> until now only released it on the success path.
> 
> Free aer_regs via ghes_estatus_pool_region_free() when
> kfifo_in_spinlocked() fails on buffer overflow.
> 
> Fixes: e2abc47a5a1a ("ACPI: APEI: Fix AER info corruption when error status data has multiple sections")
> Cc: stable@vger.kernel.org
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Signed-off-by: Priyank Rathod <rathodpriyank@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-b4-fix-aer-memleaks-v5-0-ba6b94c9c9a6@google.com?part=1