Re: [PATCH v3 03/10] rust: pci: add is_virtfn(), to check for VFs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] pci: conditional compilation bug for pci::Device::is_virtfn()
--

commit 1fc1516a8aa1429dbd6a2108303ca0548d1cd4cf
Author: John Hubbard <jhubbard@nvidia.com>

rust: pci: add is_virtfn(), to check for VFs

This commit adds a method to the PCI device abstraction to check if a
device is a Virtual Function (VF) created through SR-IOV.

> diff --git a/rust/kernel/pci/iov.rs b/rust/kernel/pci/iov.rs
> index c37ce51346731..272ed677f1451 100644
> --- a/rust/kernel/pci/iov.rs
> +++ b/rust/kernel/pci/iov.rs
> @@ -11,6 +11,15 @@
>      prelude::*, //
>  };
>  
> +impl Device {
> +    /// Returns `true` if this device is a Virtual Function (VF).
> +    #[inline]
> +    pub fn is_virtfn(&self) -> bool {

[Severity: Medium]
Does this introduce a conditional compilation issue when CONFIG_PCI_IOV
is disabled?

Since the is_virtfn method is defined in rust/kernel/pci/iov.rs, which is
entirely compiled out when CONFIG_PCI_IOV is not set, it becomes unavailable
to drivers. In the C API, the is_virtfn bitfield in struct pci_dev is
unconditionally available regardless of the CONFIG_PCI_IOV configuration.

If a Rust driver attempts to call pdev.is_virtfn() on a kernel configured
with CONFIG_PCI_IOV=n, the build will fail. Should this method be moved
to a module that is always compiled, matching the C API's availability?

> +        // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`.
> +        unsafe { (*self.as_raw()).is_virtfn() != 0 }
> +    }
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790705494.git.zhiw@nvidia.com?part=3