From: Stian Halseth <stian@itx.no>
To: Imre Kaloz <kaloz@kernel.org>, Andreas Larsson <andreas@gaisler.com>
Cc: sparclinux@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-pci@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] sparc/pci_msi: Clear the MSI descriptor irq on teardown
Date: Sat, 3 Oct 2026 21:22:56 +0200 [thread overview]
Message-ID: <20261003192256.3605029-1-stian@itx.no> (raw)
In-Reply-To: <20260927105515.8701-1-kaloz@kernel.org>
On Sun, Sep 27, 2026 at 12:55:15PM +0200, Imre Kaloz wrote:
> Since commit 2f2940d16823 ("genirq/msi: Remove filter from
> msi_free_descs_free_range()") the MSI core expects msi_desc::irq to be
> cleared by the architecture teardown before the descriptor is freed.
> sparc64_teardown_msi_irq() never clears it, so disabling MSI or MSI-X
> warns in msi_domain_free_descs() and leaks the descriptor.
>
> Clear it once the MSI has been torn down.
Tested on a SPARC T7-1 (M7) with 7.3-rc5 and ixgbe. Without the patch
the first MSI-X teardown warns at kernel/irq/msi.c:214. With it, 30
teardowns through ethtool -L and 3 unbind/bind cycles give no warning,
and the device keeps the expected number of MSI-X vectors.
Tested-by: Stian Halseth <stian@itx.no>
prev parent reply other threads:[~2026-10-03 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 10:55 [PATCH] sparc/pci_msi: Clear the MSI descriptor irq on teardown Imre Kaloz
2026-09-27 11:10 ` sashiko-bot
2026-10-03 19:22 ` Stian Halseth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003192256.3605029-1-stian@itx.no \
--to=stian@itx.no \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=kaloz@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox