Re: [PATCH v7 2/8] Bluetooth: hci_qca: Rename 'power_ctrl_enabled' to 'bt_en_available'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] bluetooth: semantic mismatch in renaming power_ctrl_enabled to bt_en_available
--

commit a629aed3c3c3f22e42d5d786579731613da2a200
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

Bluetooth: hci_qca: Rename 'power_ctrl_enabled' to 'bt_en_available'

The commit renames the 'power_ctrl_enabled' flag to 'bt_en_available' to avoid
confusion with the new pwrctrl framework. It claims the flag is used to
indicate the availability of the BT_EN GPIO in devicetree.

> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index e249fc6e44479..f53f95601693d 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -2402,7 +2402,7 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>  	struct hci_dev *hdev;
>  	const struct qca_device_data *data;
>  	int err;
> -	bool power_ctrl_enabled = true;
> +	bool bt_en_available = true;

[Severity: Medium]
Does initializing this to true imply that BT_EN is available by default, even
when it is not?

[ ... ]

> @@ -2510,7 +2510,7 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>  		    (data->soc_type == QCA_WCN6750 ||
>  		     data->soc_type == QCA_WCN6855 ||
>  		     data->soc_type == QCA_WCN7850))
> -			power_ctrl_enabled = false;
> +			bt_en_available = false;

[Severity: Medium]
For SoCs like QCA_WCN3990, if the BT_EN GPIO is missing but regulators exist,
this variable remains true because the logic to clear it is strictly limited
to WCN6750/WCN6855/WCN7850.

Does this create a semantic mismatch where the variable name suggests BT_EN is
available, but it is actually tracking whether any form of power control is
active?

[ ... ]

> @@ -2566,7 +2566,7 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>  
>  	hdev = qcadev->serdev_hu.hdev;
>  
> -	if (power_ctrl_enabled) {
> +	if (bt_en_available) {
>  		hci_set_quirk(hdev, HCI_QUIRK_NON_PERSISTENT_SETUP);
>  		hdev->shutdown = qca_hci_shutdown;
>  	}

[Severity: Medium]
The qca_hci_shutdown hook is assigned based on this flag to ensure power
control teardown.

Since this flag must remain true for devices like QCA_WCN3990 to execute the
shutdown hook to disable their regulators (even if they lack a BT_EN GPIO),
was the original 'power_ctrl_enabled' name actually more accurate?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-monza-wireless-v7-0-5a6de7662dcb@oss.qualcomm.com?part=2