Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Francisco Beltrán Millalén" <fbeltranmillalen@gmail.com>
To: d@rrell.co
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Extend Apple Thunderbolt power quirk to Alpine Ridge
Date: Thu,  8 Oct 2026 23:51:17 -0300	[thread overview]
Message-ID: <20261009025117.16225-1-fbeltranmillalen@gmail.com> (raw)
In-Reply-To: <20261008185543.85892-1-d@rrell.co>

Hi Darrell,

Thank you for testing all three patches on your MacBookPro14,3 and for
such a careful report.  It's very good to see the same results on a
second machine, and the details you sent were useful.

On Thu, Oct 08, 2026 at 11:55:42AM -0700, Darrell Gum wrote:
> - Real S3 resumed on every attempt, about half a dozen cycles
>   including lid closes on battery. noirq resume is about 16 s, with
>   about 11 s of it in each upstream bridge.

That 16 s is the ACPICA problem you mentioned in the other thread, and I
see the same thing here.  One warning before you try that ACPICA change,
though: together with this version of the quirk it makes things worse
when something is plugged in: the controller with the device attached,
and sometimes the other one too, is lost on resume until the next
reboot.  Even with nothing plugged in, the ports came back in my tests
but the thunderbolt driver logged timeouts.  I've explained why in my
reply to Bjorn in this thread; v2 of the quirk will handle it.  Until
then, I'd suggest not combining the ACPICA change with this version of
the quirk.

> - On that cycle the empty side's xHCI logged "xhci_hcd 0000:07:00.0:
>   xHC error in resume, USBSTS 0x401, Reinit" and recovered.

I see the same message here on the side with nothing attached.  With
the quirk, that controller loses power during suspend, and the xHCI
driver notices on resume and reinitialises it, so as far as I can tell
it's expected.

I'll copy you on v2.

Thanks again,
Francisco

  reply	other threads:[~2026-10-09  2:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 13:28 [PATCH] PCI: Extend Apple Thunderbolt power quirk to Alpine Ridge Francisco Beltrán Millalén
2026-09-24 13:34 ` sashiko-bot
2026-10-08 18:55 ` Darrell Gum
2026-10-09  2:51   ` Francisco Beltrán Millalén [this message]
2026-10-08 23:17 ` Bjorn Helgaas
2026-10-09  2:50   ` Francisco Beltrán Millalén

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261009025117.16225-1-fbeltranmillalen@gmail.com \
    --to=fbeltranmillalen@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=d@rrell.co \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox