Re: [PATCH for-linus] PCI/AER: Skip error recovery on false alarms

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, Oct 09, 2026 at 06:57:42AM +0200, Lukas Wunner wrote:
> On Thu, Oct 08, 2026 at 02:17:05PM -0500, Bjorn Helgaas wrote:
> > On Thu, Oct 08, 2026 at 02:26:00PM +0200, Lukas Wunner wrote:
> > > Alex is seeing a probe failure of the amdgpu driver after the Root Port
> > > above an AMD Navi10 GPU has been reset.  The reset was performed to
> > > recover from a Firmware First reported Fatal Error.
> > > 
> > > However all status registers in the Root Port's AER Extended Capability
> > > are blank, so apparently the platform firmware raised a false alarm.
> [...]
> > > Skip error recovery on false alarms, i.e. if no unmasked errors were
> > > actually signaled.
> [...]
> > Applied to pci/for-linus for v7.3, thanks!
> [...]
> > If we're confident that this also fixes the MacBookPro16,1 power-off
> > issue reported by Jason (it would be ideal if you could test this,
> > Jason), maybe it's ok to keep eddba19b8b5f plus this patch for v7.3.
> > If so, I'd like to add Jason's Reported-by and link.
> > 
> > But if we're not sure whether this fixes the MacBookPro16,1 power-off
> > issue, I think we'll have to revert eddba19b8b5f for v7.3, then squash
> > it with this fix and try again for v7.4.
> 
> Apple products with a T2 Secure Enclave will require a separate patch
> which avoids enabling Advisory Non-Fatal Errors on this particular device.
> A quirk, in other words.
> 
> I think the firmware on the T2 is upgradable in principle, but Apple isn't
> going to do us the favor to fix it.  So we don't have any other option
> than keeping a blacklist for ANFE-incompatible devices, with the T2 being
> the first device on that blacklist and maybe others to follow.
> 
> I was going to work on this for the remainder of the week, but if you feel
> the feature needs another cycle to mature, I have no objections to
> reverting eddba19b8b5f for v7.3 and re-applying it together with the two
> required fixes to pci/aer.  (The two required fixes being the one for Alex
> and the one for the T2.)

OK, it sounds like two separate issues needing two separate patches to
fix.  So I think I'll ask Linus to pull this fix today and watch for
the quirk next week.

Bjorn