From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297A246AF2F for ; Mon, 12 Oct 2026 09:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798524; cv=none; b=o1Qsbb367Z1HpMy9zov+2o0cdTcAApNgxSMYdlLPFyjIY9vK9tXu+NUWaaP8fLI+mlWFvVMyZSV11Ll7wYuFRWHooPKr5wLWeAJIZ3rM8EEZOkWBG9ij0V9Pu9bK3gfjD3kqndKdw15vAset0gk3blad2DsZx9TuBSmOvFOspjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798524; c=relaxed/simple; bh=2YXlOBKMzxFPx3DMx/2ONurojDALU3qcgugVzd5jMsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MffgnscwMFEZubk/18GegxNRd8BK/hliHdW+lMlH1rvShAfCBMLkQCNeyp4nA1C5ZJPvOJha2FEYQaGjQnaBz9sny9vTL9twUs6xrMvImzGxc+LuyvTlRgDMcZ9evHtApzsL2zMZJRS59MP0YEWFivLcbgwg5utivFIiYrjvVc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=as+AMPnd; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="as+AMPnd" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-398a5aad413so793339a91.3 for ; Mon, 12 Oct 2026 02:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791798522; x=1792403322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GGOboJZ5dJ9D0JSN3yGTlwUzv+5aJL+vgrNZ2KefTzY=; b=as+AMPndnf6BXuHnuFvkUXKq8u7l94FvNggLpdylQnWe64PUUs5WBqpOzjYi4o0Dba K6RBSX+l3Ri1PsijuNP76DGU7V2LFxrJeU6B3QlLaIS2CoQfutZm4jj63ixqg3I3F6em ebgd45Jdz6ahiW1okMXbEDAKgctTCHJu8g0ELjhSVZxQcgcv3YxnvFR1rq6xBUMh6jur 0FVAzwLo9naGaFgfGfAbskIFz5UR7Y0JRkX2d5rtQUbrSBJhQzvV4kDahLVHJRz5b/pC 0OXMSJhgeJmwFjYAJJewgyefg7zUQ09nVpicmGZ51w8bE+hWQcycK6ygbGzzBAMbp8JG k7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791798522; x=1792403322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GGOboJZ5dJ9D0JSN3yGTlwUzv+5aJL+vgrNZ2KefTzY=; b=Xe3rZ0dK/fIw1+zyL0PRVDRc97z68XBEJMKNP/ePYVkKHpK24Ff1GG7yW1SjqvDSuO 2E+UCFRxlKcLzTrQazrYgdpqJYWfeOFsobItBa3bolyy2x8G7RSN8VXnGV76dFO7XYGd ipgfDWCyadig5ohl/ZoI3RXIKWHm4nEShGjjeD/PctQhkELICzDVYgeJpwLPb1/UCnfu uJTBb3lDWe8XI6sPb1Ny7lSQI1J+pdu78J6XJuel1JD/NK7ikShbKQEQso8BRQk4poj5 Z6/85sxpvVmICJeDfPK60ZPYgmxjYNMYCHG/bLsjVNGxpi2adw47RxvIKtVCqu996uNe iykw== X-Forwarded-Encrypted: i=1; AKwUvBztaAuiSK4kzBsIByU7A9SWegFlVdk2Kw6pkN3wzf5esFSnhqv3dYoPcd1+ubZfb9dz/psABzq+V1Y=@vger.kernel.org X-Gm-Message-State: AFq9FYKz6lYD38s5pK3TpuCinv4WTNf/inCr82EmSny6e6laaEkwJGVP tUtj927sporcG0y14PzHjQjpwQtM99Q2PR3q9NETTDFxtuKK5efrUlc+ X-Gm-Gg: AYBFou0SFLg1W4fpLhWoeGQ0nD5mtVyTXIidWAdnoCPU7NFS8t1CjlyTBtXmY8vXN8u heUEzh+TE6oPhlNTYA385R4UCvh04SKLNsz/A5bjv4uPLRswj9pnyFuiA22hJvgJDBJrIPJJ5cx btUiLe98WKZAYAN+3b9INvBdUDQ1nYzFHyN4cVpgAbwtLTECPBs0s6Z6q2fpaIWs+MMENT2whsX K7eVwqcI57fL/PRZj5QoH/cjluXmeVP6LIe4L5yIaVsm0jb7a4ajPUqvpU92JRjcnHuvJxA9inn YBbxRcXEckuEq86myBqcFWv5Ycn0EViydrJ4IFFgzl48sDAOcCazRFToKP6On+CAYhlP+9L8ks4 /X4hBitmzOGMJcFQgSZvK66b/jXzfZqqg2I9yvJk+tm1V5cNvdwNA7nol/PPm1Ud4AHWlByAm0T LpzaYCFwuu1VPIiQMyGp+n2eNVTX/Fca2mYBmCnbDyb5aJ3bQDfGOOUU+jmp/w5zntJkcMi70fN LsBr1QcTq8DXV1gcgM2A+5Q4toPLe8prZ5zOZcx13D2VZmITalLPVrLnaNNBq5/ts7dgqPBEUsb nxKz/PboxTB07A== X-Received: by 2002:a17:90b:384a:b0:3a8:bb56:f1ef with SMTP id 98e67ed59e1d1-3ab3a2902a2mr7546924a91.2.1791798522450; Mon, 12 Oct 2026 02:48:42 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab36ed053csm16189628a91.4.2026.10.12.02.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 02:48:42 -0700 (PDT) From: phucduc.bui@gmail.com To: Lorenzo Pieralisi , kwilczynski@kernel.org, Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Thierry Reding , Jonathan Hunter , Manikanta Maddireddy Cc: Vidya Sagar , Niklas Cassel , linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors Date: Mon, 12 Oct 2026 16:48:15 +0700 Message-ID: <20261012094815.28160-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261012094815.28160-1-phucduc.bui@gmail.com> References: <20261012094815.28160-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc devm_gpiod_get_optional() returns NULL when the optional GPIO is not present, but may return -EPROBE_DEFER or other errors. The current code treats GPIO lookup errors as if the GPIO were not present. Check the return value and propagate errors from the REFCLK select GPIO lookup. Reviewed-by: Manikanta Maddireddy Signed-off-by: bui duc phuc --- Changes in v2: - Follow the subject line capitalization style. drivers/pci/controller/dwc/pcie-tegra194.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 2f8e828c4d9a..4c1f22b88288 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1207,18 +1207,9 @@ static int tegra_pcie_dw_parse_dt(struct tegra_pcie_dw *pcie) pcie->pex_refclk_sel_gpiod = devm_gpiod_get_optional(pcie->dev, "nvidia,refclk-select", GPIOD_OUT_HIGH); - if (IS_ERR(pcie->pex_refclk_sel_gpiod)) { - int err = PTR_ERR(pcie->pex_refclk_sel_gpiod); - const char *level = KERN_ERR; - - if (err == -EPROBE_DEFER) - level = KERN_DEBUG; - - dev_printk(level, pcie->dev, - dev_fmt("Failed to get REFCLK select GPIOs: %d\n"), - err); - pcie->pex_refclk_sel_gpiod = NULL; - } + if (IS_ERR(pcie->pex_refclk_sel_gpiod)) + return dev_err_probe(pcie->dev, PTR_ERR(pcie->pex_refclk_sel_gpiod), + "Failed to get REFCLK select GPIO\n"); return 0; } -- 2.43.0