From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793055307; b=rOG8aT47Rb2uYmpHkw1O7PT1wSE2exZTC+9epJ/zoaMO3fOqXajkgackINgCY9oDEZaZ c8fdTxS3bbo52v1c3f/KyYVMFwNTXNs2qwkzjQHPXYuC18is09rvPxjUVcKGJZYKU9LGF LVslr7COsAgF2HWq7Up39LQVRMziw66JuzkMkyW6DnL2SukkEyggDXKvbJyqGNhIY/5XW zHDMz5mLi+tLFhARGvUjzHUuilSR83uoK7HPWhsSq1giusFuK2HbaAj4pwD/QDkiNoGdi 3JVIQoZOHe6HY6W4ekpjdV0JMGtoizeb9Q6nV35S2WniMRK2Y3hdaUWO544YDoseZng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793055307; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=Qv4yXz9mBS7TK9aKYpPIFfG0d3O9zFyQxnBKda+GG2U=; b=QjLkzuz5BUNNJUh1dJTlqsPa2HEsldLlIIJSoOY96/cM5ksP/CERo0+fjOLLIFbLEaol OdopH7EvWMi9DLjW/trXZqv/bQqSoeoeMWsCJ04NR5yrKOKE1MBZ3bYspx/vKjRRDTVMw q41rl7GqP5mqJNsLUCWdTUKJgjAfmdecl/akzmmpeJlzVIOkO7oIG9NJ5xRHWljFJGc0Z MpzyYL/ow5gR5rg/UXytopk0HO6ibrib23rAz/uXKfo48hXpFRCBalkR+o54O5WNxH9uA bAXPW4ZOSjm0ghCBtYh1m7T/zG//X9Nsxik2308QsVpqxnB2yg8Pe2GLnYRg8ab0J7A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=iE1vhkuf; arc=none smtp.remote-ip=209.85.160.179 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53434606A31D for ; Mon, 26 Oct 2026 22:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 53434606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=iE1vhkuf Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-5364c951da4so32191801cf.1 for ; Mon, 26 Oct 2026 15:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1793055306; x=1793660106; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Qv4yXz9mBS7TK9aKYpPIFfG0d3O9zFyQxnBKda+GG2U=; b=iE1vhkufDNk47J0y0sfQfrcXvv7YwF5xZFg9Zgo3GIzWAPWbTFVaeyw2U0dtOlPag2 5dWMf7SyNSgNhsm9D6diSHIdA69bKNuWJ33g6Ws86B/FXC72+OUoK0GlOXNcOXMMUb7j vEQdmCqpATKVE6+OWcRHTpwNRrYJBNMNiiH9SbBKxx83oBE7NDzOB6NP/kzPMrB7tS1u BJ8R/xA3Vtfw1W0CvF40clDWUJO6jz0fi1k5djJewrxA40gh6oNqWlI/rreVaHKQhFSf 2D4NvJf4yKKhk9yrS9MArPN93WnWZW895J1xZMvYhJ7gHZqrZyRRpjbacUJzAeaZicS/ ct0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793055306; x=1793660106; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qv4yXz9mBS7TK9aKYpPIFfG0d3O9zFyQxnBKda+GG2U=; b=bKle4xJrp3jYCZdc4fwfEvWn2Mte9BLllVwNnx9RQ5Z7bA7qVCEtfYGoyh+FY3plkq pXcTTVxDe5sqSw4vt+sbdoksAye6fCmgNHtTi1CkD/7DczYHkRWHL5C8f442xQM+yx4s ekd4ixiZcWXfGoHWpHg412nTIxTfkn8Z/4sMfnwRHI+6bq+Asv0a4644nJ42mwm7DJTF 099n5lr8wTS67aurY1+1E1So5730dkNWWYGSwlyDlyoYwAd1SH18oxwkM1Znx+mZg3KG OeRyzvgbOlXI43FBA0IaX3xT/f0ylxlS9toQfCA/KV25MgVOdYerH5XFP5e+NjR/Tr0K MW3w== X-Forwarded-Encrypted: i=1; AKwUvBydhYx0q5NhuAdhpzW71M38w7ytPHMdkY3OAuqCQwpvHSf9NJtiGd8hgucoYk+InHEpGc0FbR5ok78=@vger.kernel.org X-Gm-Message-State: AFq9FYIEWX5Gaxan47lKJ+dj3aL1y+cCj6uEkEXVWFMChVNXaQ4QMEou STPpty37CKsC7hP2bKheHP/NvCSr+RRtqPWwCaCUc/Cd7Yr0WpWX85wL9m4pQ10NhiY= X-Gm-Gg: AYBFou0B+/L4dmOsjWmgaSUMaYWlpdYN4K0TjlYUVNahvhDrcaczIsDBZvvoZ4C+F9Y QDczqHnGwNOeqZJ3uNM9ESp8PGhaQ+9X+r/lzsgbKyNWUFMa4eIT9el53rY/L2DnC/ERZplmiP2 gSiRFxXBCL4nFzJz8Rk6FErFaE/Akp5VMpLpv1f/cU6E6xDdfNRXCsPz0Iqo8VoZea86kyWg4pm bdFclIGDengB3X37qHLQARrnfKCpBZBd6jXr+66iUzdl86DvYowt28vjMkZh58APIeA9rEsqSMZ BAWjUYe4PSk2W4ike5npSSezyEXeZONItXi4kRytCYGQ6rkSLKb8vJc0Ug1T3NtMQZKGS/XZCzy uQqBIMGdDcO3kWJ6Jnqkc6Lr8wggX/l+eJaz3wrReAfaUdUQxhjHNGBDxz3/KirPZjY9WZJeiF7 bz6opgGC0pAS7KMQ7w903CBP/7hbRrrRpefGJ8HQxG54vs1Q/kup0QHX6m2hf3u6vXs8oQo8iqE rdYb4ugEd2YJ3bkpulAuL3ZOJont+5KDUML0kTkr5hV5ChiR3W/j8wAQBgfcH3wXFuWckQ/B21N gyKFQMwj6HlpuEY0kOkRIdTMwAWEe129MB/IRw== X-Received: by 2002:a05:622a:4b18:b0:535:80b:9911 with SMTP id d75a77b69052e-5383b4b0e1dmr122069761cf.24.1793055306222; Mon, 26 Oct 2026 15:55:06 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-538394c565esm66284051cf.6.2026.10.26.15.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 15:55:05 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xLTaq-000000088rN-3CrV; Mon, 26 Oct 2026 19:55:04 -0300 Date: Mon, 26 Oct 2026 19:55:04 -0300 From: Jason Gunthorpe To: Greg Kroah-Hartman Cc: Leon Romanovsky , Alex Williamson , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Armin Wolf , David Lechner , Danilo Krummrich , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Jonathan Corbet , Shuah Khan , Randy Dunlap , "Rafael J. Wysocki" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Bradley Morgan , Aleksandr Nogikh , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-usb@vger.kernel.org, driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org, Johan Hovold , Richard Weinberger , Thierry Reding , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: [PATCH v4 0/3] driver core: add TAINT_FORCED_BIND for when userspace manually messes with devices and drivers Message-ID: <20261026225504.GC1685504@ziepe.ca> References: <9bd3a34b-5e98-4038-80d6-da2c3b1948dd@gmx.de> <2026092321-province-yearly-44aa@gregkh> <2026092348-victory-erased-0e5a@gregkh> <20261023181326.0dc2f7ed@shazbot.org> <20261026122243.GA28851@unreal> <2026102654-enlighten-perkiness-193c@gregkh> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026102654-enlighten-perkiness-193c@gregkh> On Mon, Oct 26, 2026 at 09:27:25PM +0100, Greg Kroah-Hartman wrote: > > > Sorry, late to the party, but this isn't a few user scripts that rely > > > on this behavior. Effectively every use case of vfio relies on this > > > behavior. We rely on unbinding the default driver from the device > > > before using driver_override and drivers_probe. That means every > > > hypervisor with device assignment and every userspace driver use case > > > now experiences a tainted kernel. That seems like a significant > > > regression. > > > > Sorry, I was on vacation and missed this change earlier. This change will > > affect SR-IOV deployments around the world, which *rely* on being able to > > bind a driver manually *after* virtual functions are created but before > > they are used. > > Why can't a real driver bind to those virtual functions? Like is > happening in the rust apis? Most people using SRIOV will bind the VFs to the VFIO driver. The rest, it is the same as the CC case, there needs to be a gap after creating the PCI VF functions and before binding a real driver, with a proper match and a correct id. This is usually managed by clearing drivers_autoprobe Ie look at commit b8c5cec23d5c ("Driver core: udev triggered device-<>driver binding") from 2007 explaining this workflow. The taint on sysfs unbind makes zero sense here because we can trigger unbind of those VFs just by disabling SRIOV through sysfs. Should we taint that too? > > This is needed for two reasons: to save hardware and software resources > > when creating a large number of VFs, and to allow the PCI config space to > > be configured *before* the driver starts using it. > > How is hardware and software resources an issue here at all? If you create a 1024 VFs, which is what people on big servers seem to do, then that can use 1024 x megabytes of resources to load all those drivers which will memory exhaust a hypervisor. This is a real case actual users run into, I saw the support requests go by :| > And you can write to PCI config space from userspace today, Not allowed in lockdown, triggered by secure boot, which pretty much every server uses. > > There is no in-kernel alternative. > > Then just don't have a in-kernel driver for the device and all is good? What? How do you use the HW then? Is this a serious reply? Jason