From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793264300; b=U6DviMeYDmvllWvwrM4vz44tMpdM2qEXG7yLmMgzyQWtA0wOg4ABHYKqueh/dpNuhrud Fm2kgAeHtHH0a8OGM/COmHO2TeAw5CzA3UUM8ul/AyoYB1ytglCkQlyYNJKCOh9v3nRcL SVKmkRHv8Dx4nsc9W9vm0Mf0h4goFD0ocuyd/6aB6wQadepYwnZROQ22U+WYGi36slJy+ JWET5CKVbOASwOKIRxZJmduVLzxVGfyS0o+2H5BROFMhhiSGQKfSdpW5ucUAUeuMKe60z gXTxH8oSEQNYvm/O2/oF6doSH95iLKrI48W5OxP328wSRzwsQP84BuXsUlQJJrwoNHQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793264300; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=aLiKz2BhC5RSo/yb+qOUrvZd9mNsTY8Su064dE1oXf0=; b=mPiiXJBMLc3FMVetd+ozwK9gynRLF5UE9oT6zXJi/Vyg/htJl9RnsO9xuxYI1L8Rrmvg eT3Xj1OSAS0EwqFOpxHohvm5nWHy7H9PJHhltaSntoBJ5BUyYNN7qMqdi6itbM7TZ49RA GxyxPhHkEcWqCG9g68UPjaj3oRJRzjxbc1/SmWMyVez8za4WtdygoouZnwmAw6afsG9Do MD2gM2zqZQw+Go4rJ9lcXQt4/rhg1UDh5/KEPC/zTlFfc+pyTgMTAlsKX1GdzsuKfHzzu IeO8gSPnWKOwYkc0DpN6yGl19mXDDJrzgrKx+DtoPZSIisdhe6kbD4U1zO2Ux7viS9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=KQoOinV7; arc=none smtp.remote-ip=74.125.82.174 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96F97606A31A for ; Thu, 29 Oct 2026 08:58:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96F97606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=KQoOinV7 Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-369f33df08eso3514012eec.0 for ; Thu, 29 Oct 2026 01:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793264299; x=1793869099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aLiKz2BhC5RSo/yb+qOUrvZd9mNsTY8Su064dE1oXf0=; b=KQoOinV7IsGlJE90LxDtr2QI3uALtgcoSmDANpVDPtmt5mpbR8DXDfNVF7gEwRt5wL HQzdud2i6m2MnLNgQKOPpbdfXP9efFtOK9sYRcIxL/NX9dzCki+ltfIZKPO0yKmyMB/q qjPhgKDy3qnsQZbAxGd19//WshWQsDzZAKIeLadg086NjnOeZ4xzlXYPcfEPRva9tupQ SQ422nlARNA0ESodQw9rQ489f6thndM7qem9yBKyLm7ZY8EAVLs8zhKlKpNatt46ZQS5 TYN6s6pdkNHk/xc5HRyRZLfhQoLoqftzOWF+tcJdgrfI+c8PJes6M/79OIJGYfWL+3GH VRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793264299; x=1793869099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aLiKz2BhC5RSo/yb+qOUrvZd9mNsTY8Su064dE1oXf0=; b=TZBtjCWSwgL0LJpkrmckPtfZVoFd7a85sPFWS2jmajeO79BuBwtq14sBAb2+bgd94f K8cVeCh8zyA9oW39WBSYcHCn+Al0C4ljafErVrkXpDgNstaa00VRthjXZd+cm5hCdHRH eqexISGiE5Bs5Za4j4IHebHbTIr9y4/NjRQ6kRxcDfS8E3gyS4TYxLzdmetwmFEQGUFC IrbXmAgenBmil0Zm7QXbjdiIuTs+ORfKhzeMxKl7FIuBmzWUGDH2iOsPSBsDN/TliXR3 XgKWTJ5y23XPyOVQgOx+cGBeoKgHlpkQhEO2m8NmtqZEOeWXXimfBW5DOvScVbBgDmf3 rAew== X-Forwarded-Encrypted: i=1; AKwUvBwJR9IJQvMdo57107KvUnE0EI19rG+WRoLHdwpMGqmbqBACIdgjzh8CIyFXBE5HmMcXFyXygom83zw=@vger.kernel.org X-Gm-Message-State: AFq9FYJmCYFZUtFNKbrMn8y6l/WH18SXFVP73VG5YqoW/274FWmtoXcU uMQVP9HUeAj6+hbSdFpfXV3myHeaT5K9HdNvzhAybw5t98L8C4f4CBk= X-Gm-Gg: AYBFou09PxoAl+jGtU8rBimR81b6ilABq7zIenSI0KtFJ2I9wYRtTCh2FYVTCo2iXzV lMX97PcZv9/vL75IB4BNdk280l4j/+yQpFBYtYM5Bq7Cgmp7Ccdi2zVp1T3J4l5x4Wd21khEbCQ 1tLtMYNLSrEjV9E+9w0gC/uGJFKdyIXTW3rArHi5uepJr9tyb5uOjJvQILQRTbcnFmf0CvPOFGI T0vt9XjKoEw7kg8QK1w/A0tXvljUp0JEh0TmSrjtmAIbddQ4Wcu7LXFlSkuetEp2TzPX9dSu/XF P1Rb5dK91uSU1yVvRE49jLCi31Rgjp7YOhhtL6EN4eCzZHHwByma/d7acwJPDvI6N7HA7UQkacB 5C9sY6MQ8P3qRVN7YRHD11HFuWuIvLAsfbzK1Nq7xmhifzO6rSWKXkg9orCkdXP5Q6WD0PcUN3n W5fb/VvOI8ZX0DzNyq0zk8gG6XKIBwbz2Fnb9ITxrLfahaXVNLnNernrtd2zd4NaAvHKDr/1i7h cd4VVZLCZUa4vwEm5u3XbIjAryO38loyJW3fWxVfhaIZc38K7VKifx5PdtWCVnm3fAJfBHM6FLy jlhMUDrSijH7lLmMvV5mXXZVABYFIZScSPwDuaEhyITvfY7eHMLW9f4IE0FPxg== X-Received: by 2002:a05:693c:8944:10b0:369:2f25:33a7 with SMTP id 5a478bee46e88-36a200beec9mr6691678eec.15.1793264298696; Thu, 29 Oct 2026 01:58:18 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009 ([27.60.20.232]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a23641e78sm16497937eec.0.2026.10.29.01.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 01:58:17 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Linus Walleij , Bartosz Golaszewski , Sven Peter , Janne Grunau , Neal Gompa , Guenter Roeck , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Lee Jones , Pavel Machek , Griffin Kroah-Hartman , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sebastian Reichel , Alexandre Belloni , Wim Van Sebroeck , Jarkko Sakkinen , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, mfd@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [RFC PATCH 05/14] iio/accel: add driver for apple SMS Date: Thu, 29 Oct 2026 04:52:02 -0400 Message-ID: <20261029085504.3547-6-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> References: <20261029085504.3547-1-atharvatiwarilinuxdev@gmail.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a driver for the Sudden Motion Sensor accelerometer, exposed through IIO. It reports the three axes and also drop, orientation and shock events. This replaces the motion sensor support in applesmc. Signed-off-by: Atharva Tiwari --- drivers/iio/accel/Kconfig | 10 ++ drivers/iio/accel/Makefile | 1 + drivers/iio/accel/macsmc-accel.c | 248 +++++++++++++++++++++++++++++++ drivers/mfd/macsmc-core.c | 10 ++ 4 files changed, 269 insertions(+) create mode 100644 drivers/iio/accel/macsmc-accel.c diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig index 141ac9842..50bc127a4 100644 --- a/drivers/iio/accel/Kconfig +++ b/drivers/iio/accel/Kconfig @@ -532,6 +532,16 @@ config KXCJK1013 To compile this driver as a module, choose M here: the module will be called kxcjk-1013. +config MACSMC_ACCEL + tristate "Apple SMC Motion Sensor Driver" + depends on MACSMC_ACPI + help + Say yes here if you want support for Apple Motion Sensors, that uses + the System Management Controller. + + To compile this driver as a module, choose M here: the module will + be called macsmc-accel. + config MC3230 tristate "mCube MC3230 Digital Accelerometer Driver" depends on I2C diff --git a/drivers/iio/accel/Makefile b/drivers/iio/accel/Makefile index fa440a859..52fe661de 100644 --- a/drivers/iio/accel/Makefile +++ b/drivers/iio/accel/Makefile @@ -54,6 +54,7 @@ obj-$(CONFIG_KXSD9) += kxsd9.o obj-$(CONFIG_KXSD9_SPI) += kxsd9-spi.o obj-$(CONFIG_KXSD9_I2C) += kxsd9-i2c.o obj-$(CONFIG_MC3230) += mc3230.o +obj-$(CONFIG_MACSMC_ACCEL) += macsmc-accel.o obj-$(CONFIG_MMA7455) += mma7455_core.o obj-$(CONFIG_MMA7455_I2C) += mma7455_i2c.o diff --git a/drivers/iio/accel/macsmc-accel.c b/drivers/iio/accel/macsmc-accel.c new file mode 100644 index 000000000..0abf81e7b --- /dev/null +++ b/drivers/iio/accel/macsmc-accel.c @@ -0,0 +1,248 @@ +// SPDX-License-Identifier: GPL-2.0-only OR MIT +/* + * Apple SMC sudden motion sensor (SMS) driver + * + * Copyright (C) 2026 Atharva Tiwari + * + * Based on drivers/hwmon/applesmc.c: + * Copyright (C) 2007 Nicolas Boichat + * Copyright (C) 2010 Henrik Rydberg + */ + +#include +#include +#include +#include +#include +#include +#include + +struct macsmc_accel { + struct apple_smc *smc; + struct iio_dev *indio_dev; + struct notifier_block nb; +}; + +enum { + SMS_DROP = 0, + SMS_ORIENTATION, + SMS_SHOCK, +}; + +static int macsmc_accel_read(struct macsmc_accel *drv, smc_key key, s16 *p) +{ + int ret; + + ret = apple_smc_read_s16(drv->smc, key, p); + if (ret < 0) + return ret; + + *p = (s16)be16_to_cpu(*p); + return 0; +} + +static int macsmc_accel_dev_init(struct macsmc_accel *drv) +{ + int ret, total; + u16 buf; + + for (total = 0; total < 100; total++) { + ret = apple_smc_read_u16(drv->smc, SMC_KEY(MOCN), &buf); + if (!ret && buf) + return 0; + + buf = 0xE0; + apple_smc_write_u16(drv->smc, SMC_KEY(MOCN), buf); + msleep(50); + } + + return -ENODEV; +} + +static int macsmc_accel_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct macsmc_accel *drv = iio_priv(indio_dev); + int ret; + s16 buf; + + if (mask != IIO_CHAN_INFO_RAW) + return -EINVAL; + + switch (chan->channel2) { + case IIO_MOD_X: + ret = macsmc_accel_read(drv, SMC_KEY(MO_X), &buf); + if (ret < 0) + return ret; + + *val = buf; + return IIO_VAL_INT; + case IIO_MOD_Y: + ret = macsmc_accel_read(drv, SMC_KEY(MO_Y), &buf); + if (ret < 0) + return ret; + + *val = buf; + return IIO_VAL_INT; + case IIO_MOD_Z: + ret = macsmc_accel_read(drv, SMC_KEY(MO_Z), &buf); + if (ret < 0) + return ret; + + *val = buf; + return IIO_VAL_INT; + } + + return -EINVAL; +} + +static int macsmc_accel_event(struct notifier_block *nb, unsigned long event, void *data) +{ + struct macsmc_accel *drv = container_of(nb, struct macsmc_accel, nb); + u64 code; + + /* check if event is for us */ + if (event != 0x60 && event != 0x69 && event != 0x6F) + return NOTIFY_DONE; + + switch (event) { + case 0x60: + code = IIO_UNMOD_EVENT_CODE(IIO_ACCEL, SMS_DROP, + IIO_EV_TYPE_CHANGE, + IIO_EV_DIR_NONE); + break; + case 0x69: + code = IIO_UNMOD_EVENT_CODE(IIO_ACCEL, SMS_ORIENTATION, + IIO_EV_TYPE_CHANGE, + IIO_EV_DIR_NONE); + break; + case 0x6F: + code = IIO_UNMOD_EVENT_CODE(IIO_ACCEL, SMS_SHOCK, + IIO_EV_TYPE_CHANGE, + IIO_EV_DIR_NONE); + break; + } + + iio_push_event(drv->indio_dev, code, iio_get_time_ns(drv->indio_dev)); + return NOTIFY_OK; +} + +static void macsmc_accel_unregister_notifier(void *data) +{ + struct macsmc_accel *drv = data; + + blocking_notifier_chain_unregister(drv->smc->event_handlers, + &drv->nb); +} + +static const struct iio_event_spec macsmc_accel_event_spec = { + .type = IIO_EV_TYPE_CHANGE, + .dir = IIO_EV_DIR_NONE, + .mask_separate = BIT(IIO_EV_INFO_ENABLE), +}; + +static const struct iio_chan_spec macsmc_accel_channels[] = { + { + .type = IIO_ACCEL, + .modified = 1, + .channel2 = IIO_MOD_X, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + }, + { + .type = IIO_ACCEL, + .modified = 1, + .channel2 = IIO_MOD_Y, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + }, + { + .type = IIO_ACCEL, + .modified = 1, + .channel2 = IIO_MOD_Z, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + }, + { + .type = IIO_ACCEL, + .channel = SMS_DROP, + .event_spec = &macsmc_accel_event_spec, + .num_event_specs = 1, + }, + { + .type = IIO_ACCEL, + .channel = SMS_ORIENTATION, + .event_spec = &macsmc_accel_event_spec, + .num_event_specs = 1, + }, + { + .type = IIO_ACCEL, + .channel = SMS_SHOCK, + .event_spec = &macsmc_accel_event_spec, + .num_event_specs = 1, + }, +}; + +static const struct iio_info macsmc_accel_info = { + .read_raw = macsmc_accel_read_raw +}; + +static int macsmc_accel_restore(struct device *dev) +{ + struct macsmc_accel *drv = dev_get_drvdata(dev); + + return macsmc_accel_dev_init(drv); +} + +static const struct dev_pm_ops macsmc_accel_pm_ops = { + .restore = macsmc_accel_restore, +}; + +static int macsmc_accel_probe(struct platform_device *pdev) +{ + struct macsmc_accel *drv; + struct iio_dev *indio_dev; + int ret; + + indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*drv)); + if (!indio_dev) + return -ENOMEM; + + drv = iio_priv(indio_dev); + drv->smc = dev_get_drvdata(pdev->dev.parent); + + ret = macsmc_accel_dev_init(drv); + if (ret) + return ret; + + drv->indio_dev = indio_dev; + drv->nb.notifier_call = macsmc_accel_event; + ret = blocking_notifier_chain_register(drv->smc->event_handlers, &drv->nb); + if (ret) + return ret; + + ret = devm_add_action_or_reset(&pdev->dev, macsmc_accel_unregister_notifier, drv); + if (ret) + return ret; + + platform_set_drvdata(pdev, drv); + + indio_dev->name = "macsmc-accel"; + indio_dev->modes = INDIO_DIRECT_MODE; + indio_dev->info = &macsmc_accel_info; + indio_dev->channels = macsmc_accel_channels; + indio_dev->num_channels = ARRAY_SIZE(macsmc_accel_channels); + + return devm_iio_device_register(&pdev->dev, indio_dev); +} + +static struct platform_driver macsmc_accel_driver = { + .probe = macsmc_accel_probe, + .driver = { + .name = "macsmc-accel", + .pm = &macsmc_accel_pm_ops, + }, +}; +module_platform_driver(macsmc_accel_driver); + +MODULE_AUTHOR("Atharva Tiwari "); +MODULE_DESCRIPTION("Apple SMC Motion Sensor Driver"); +MODULE_LICENSE("Dual MIT/GPL"); +MODULE_ALIAS("platform:macsmc-accel"); diff --git a/drivers/mfd/macsmc-core.c b/drivers/mfd/macsmc-core.c index 6014df4fe..6567d2f1f 100644 --- a/drivers/mfd/macsmc-core.c +++ b/drivers/mfd/macsmc-core.c @@ -24,6 +24,10 @@ static const struct mfd_cell apple_smc_rtkit_devs[] = { * There isn't device tree on acpi backend, so we need to use * apple_smc_key_exists to register mfd devs */ +static const struct mfd_cell apple_smc_acpi_accel[] = { + MFD_CELL_NAME("macsmc-accel"), +}; + static const struct mfd_cell apple_smc_acpi_common[] = { MFD_CELL_NAME("macsmc-hwmon"), MFD_CELL_NAME("macsmc-power"), @@ -169,6 +173,12 @@ int apple_smc_probe(struct device *dev, const struct apple_smc_backend_ops *ops, return ret; } + if (apple_smc_key_exists(smc, SMC_KEY(MOCN))) { + ret = devm_mfd_add_devices(dev, -1, apple_smc_acpi_accel, + ARRAY_SIZE(apple_smc_acpi_accel), NULL, 0, NULL); + if (ret < 0) + return ret; + } } else ret = devm_mfd_add_devices(dev, -1, apple_smc_rtkit_devs, ARRAY_SIZE(apple_smc_rtkit_devs), NULL, 0, NULL); -- 2.55.0