From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.199 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793925779; b=Rzi1ke/fX20+ePg7xtF0IYwOWtZo1wOeheW7eJUCMpi05vLtyoDCFZ28IkwyTSGH9cn2 ba99HKjVqlPxDFx1/Kp4npFanAQPueJi2wDQSty41++7JVlhQC/IgyF/KjShi8J7k2vcx OmwDKkd/UQ4YH5aI4N3rl0D31swUY3nfA4W3EdktghpV7U3YQpXfpoBfBzproF7EvJTmr GHvCBiodGESNX3mNk0LFn0HcDldMkYJ6AG4SGAt+2iUgo/wKJSFU/m/VyB/hWOb04fdVu /+u083KCo+pnLUV8i0N15a/wtJROpJOBxC5GZifO15TA0MsIeqnOaf/NrpS/BcmA7AQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793925779; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=BPfp4nLyt9FVdmFE1yKT2sRgCODHAPIFVB7rkcjEfkI=; b=b/KiAaiCqBWYSpF61HnHbgaENwxRXYnh6pcDuMjaFeKpkAgTzUTILiWpKqEzXv6R6bPY q3LdA4LxyGFejtf5OOs+sdgQix16wTRw2+/MKYqC2ehBKHDXyd01q2IkIpRUx4RTJCt85 dAGw19ThSo/zdkw8vo3nCnTMotdVKH75neXcD/ieqXWpEv4Lq7DLfNDfkvGxkRRojzRr0 JmIWpzrH1kOMDFuU9Dzv6riEv2Red5BD65nfPVplZNonAtb5HScWyffse9VtE1hPPvbNk y7IeHRqRRZjCaVaVcS2SY9leBcaKrJlzCGNpo1QZVdGgF7WTCJ0a0ppV22ghyJr7t6Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=pZjogpE8; arc=none smtp.remote-ip=209.85.167.199 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB409606A335 for ; Fri, 6 Nov 2026 00:42:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DB409606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=pZjogpE8 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-4fb73e868aaso102304b6e.0 for ; Thu, 05 Nov 2026 16:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793925778; x=1794530578; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BPfp4nLyt9FVdmFE1yKT2sRgCODHAPIFVB7rkcjEfkI=; b=pZjogpE8Ak8WHFpInkUSeG3P5zHU/+5iZFj7i51qTUVRnAd1vBlLYjXTRAvj3M1Kc3 coFXIGXgiqDnbXVvEzruLsSocs2bwIAlnBJRm0GqAbhcG0BLa/qHPcKbYjLywgIigNcF mraoBr5QVaxrMNMSLKKIO12AHJb873pDK4NQdRFi3PzHmG2Y7Z+lOCTAyJv6Q6O2TJ8m TLEsPs/EXtljGzI0mIxJlfCTyAT7r8ABDEnr2nsnSzD4oLz8Z3tdsYRUUMrvZaySfE2j LMr9v4i38jYaMOZVwhrvKwF0uAuDmXaCQd4y+7nsCMbxVvzR4B6XVCA4eFVJ/UA5DxPz NwRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793925778; x=1794530578; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BPfp4nLyt9FVdmFE1yKT2sRgCODHAPIFVB7rkcjEfkI=; b=fXgtsOZOwJxQjp29mZLa1MTut4T4iDTY0B67D10SFyFUPDVA+csdBaifrf8WqqcmeG 57H3PWJwcjVNMMDWMf3w0d3zSo1dOCzTbYhNGncCzuk5AX/JMtIIUBuPf8FK2b5lKCbh ZWEjbiKtWqz7SrWspHPpMeTsc2yaEHlBbdvRJsDOEhvk+G+W3L9r+MIJbYMmEx99kNry Peji7WIwtLwAYBu9Q2m5HMAv3kW/J9wZ5mnpDK26PWQEkuxZxxVL7NYOxWjJstFJt+0Y ZPBSkiV4kWaC5beWIRHOl27pz9bkp6zh00F2nK7BOE6m405w3bdhefzd78Soi3tln/GG W3bQ== X-Forwarded-Encrypted: i=1; AKwUvBxPAc9AZJuUBd3Y56OiEIOC+c9Gy7Epnlhs++bBLp/A9GZvLVrk5z0Yg53sy/YTqejYfD89SUi7Tck=@vger.kernel.org X-Gm-Message-State: APuU4Z8l3HVjNmbJFxQ4cjLrKaJAcQ/lN32ezlg0Qu9DyZs7zaKI8E4x zbTLmop3YhA38gvFcTngm7GfmuY1P5any89KZ5mLeDrjqkyU4WSR3myBvAWUwN39ELISKkWhsz2 jEkCAkJ1ifcs3og== X-Received: from jahl14-n2.prod.google.com ([2002:a05:6638:8c0e:20b0:620:17bd:8c69]) (user=dmatlack job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:2216:b0:4d6:9355:7547 with SMTP id 5614622812f47-567e1840a0cmr681897b6e.66.1793925777406; Thu, 05 Nov 2026 16:42:57 -0800 (PST) Date: Fri, 6 Nov 2026 00:42:02 +0000 In-Reply-To: <20261106004218.604799-1-dmatlack@google.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261106004218.604799-1-dmatlack@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261106004218.604799-2-dmatlack@google.com> Subject: [PATCH v2 01/17] PCI/DPC: Allocate the DPC save buffer during device setup From: David Matlack To: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Alexander Graf , Alex Williamson , Bjorn Helgaas , David Matlack , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Lukas Wunner , Mahesh J Salgaonkar , Mike Rapoport , "Oliver O'Halloran" , Pasha Tatashin , Pratyush Yadav , Randy Dunlap , Samiullah Khawaja , Shuah Khan , Vipin Sharma Content-Type: text/plain; charset="UTF-8" Allocate the DPC capability's save buffer in pci_dpc_init() rather than in dpc_probe(), and report an allocation failure, which dpc_probe() ignored. dpc_probe() runs when the portdrv DPC service binds to a port, which is long after the device has been added, and does not happen at all if the service is not enabled. Until then pci_save_dpc_state() silently saves nothing, so a reset in that window loses the DPC Control register. Allocating during device setup makes buffer existence depend only on the capability being present, which is what the save and restore paths already assume. It also puts every capability save buffer in one phase of a device's life, which a later patch relies on. Signed-off-by: David Matlack --- drivers/pci/pcie/dpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 2b779bd1d861..b7f79266f66d 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -408,6 +408,9 @@ void pci_dpc_init(struct pci_dev *pdev) if (!pdev->dpc_cap) return; + if (pci_add_ext_cap_save_buffer(pdev, PCI_EXT_CAP_ID_DPC, sizeof(u16))) + pci_err(pdev, "unable to allocate suspend buffer for DPC\n"); + pci_read_config_word(pdev, pdev->dpc_cap + PCI_EXP_DPC_CAP, &cap); if (!(cap & PCI_EXP_DPC_CAP_RP_EXT)) return; @@ -499,7 +502,6 @@ static int dpc_probe(struct pcie_device *dev) FLAG(cap, PCI_EXP_DPC_CAP_SW_TRIGGER), pdev->dpc_rp_log_size, FLAG(cap, PCI_EXP_DPC_CAP_DL_ACTIVE)); - pci_add_ext_cap_save_buffer(pdev, PCI_EXT_CAP_ID_DPC, sizeof(u16)); return status; } -- 2.56.0.455.g6c5a503b38-goog