Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Oliver OHalloran <oohall@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Sathyanarayanan Kuppuswamy
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Keith Busch <kbusch@kernel.org>,
	Maciej Grochowski <Maciej.Grochowski@sony.com>,
	Ilpo Jaervinen <ilpo.jarvinen@linux.intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v2 0/2] PCI/AER: Improve Error Source handling
Date: Mon, 9 Nov 2026 17:36:53 -0600	[thread overview]
Message-ID: <20261109233653.GA349541@bhelgaas> (raw)
In-Reply-To: <cover.1793982724.git.lukas@wunner.de>

On Fri, Nov 06, 2026 at 05:38:00PM +0100, Lukas Wunner wrote:
> While analyzing log output provided by Alex, I noticed that the AER driver
> fails to find the error-signaling device if the Error Source ID register
> contains an invalid, non-zero value.  Fix it (patch [2/2]).
> 
> While at it, fix a potential NULL pointer deref in that portion of the code
> (patch [1/2]).
> 
> Changes versus v1 in patch [2/2]:
>   Reorder a < b && b < c comparisons (Ilpo, Bjorn)
>   Amend kernel-doc of find_source_device() (Sathya)
>   s/subordinate/secondary/ in commit message (Bjorn)
>   Document behavioral change in commit message (sashiko)
> 
> Link to v1:
>   https://lore.kernel.org/r/cover.1793697480.git.lukas@wunner.de
> 
> Lukas Wunner (2):
>   PCI/AER: Avoid NULL pointer deref on search for Error Source
>   PCI/AER: Check validity of Error Source ID register
> 
>  drivers/pci/pci.h       |  7 ++++++-
>  drivers/pci/pcie/aer.c  | 37 +++++++++++++++++++++++++++----------
>  drivers/pci/pcie/rcec.c | 14 ++++++++++++++
>  3 files changed, 47 insertions(+), 11 deletions(-)

Applied to pci/aer for v7.5, thank you!

      parent reply	other threads:[~2026-11-09 23:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 16:38 [PATCH v2 0/2] PCI/AER: Improve Error Source handling Lukas Wunner
2026-11-06 16:38 ` [PATCH v2 1/2] PCI/AER: Avoid NULL pointer deref on search for Error Source Lukas Wunner
2026-11-06 17:01   ` sashiko-bot
2026-11-06 16:38 ` [PATCH v2 2/2] PCI/AER: Check validity of Error Source ID register Lukas Wunner
2026-11-06 17:07   ` Ilpo Järvinen
2026-11-06 17:15   ` sashiko-bot
2026-11-06 17:25     ` Lukas Wunner
2026-11-06 17:37       ` Ilpo Järvinen
2026-11-09 23:36 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109233653.GA349541@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Maciej.Grochowski@sony.com \
    --cc=alexander.deucher@amd.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kbusch@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=oohall@gmail.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox