Re: [PATCH 2/4] PCI/AER: Clamp negative ratelimit burst to zero

[Yazen Ghannam <yazen.ghannam@amd.com>]

On Tue, Nov 10, 2026 at 10:02:27PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found no new issues
> in this patch, but noticed 1 related pre-existing issue it does not
> introduce:
> - [Medium] PCI/AER: incorrect unit scaling in
>   aer_ratelimit_interval_attr() [1]
> --
> 
> commit 3e212613eb554aa7ec8ef93c898bf101c6bb444e
> Author: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> PCI/AER: Clamp negative ratelimit burst to zero
> 
> This commit clamps negative values written to the AER ratelimit burst sysfs
> attributes to zero and updates the ABI documentation accordingly.
> 
> > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> > index 6f24602314225..401cd3a1b3d0e 100644
> > --- a/drivers/pci/pcie/aer.c
> > +++ b/drivers/pci/pcie/aer.c
> > @@ -752,6 +752,9 @@ const struct attribute_group aer_stats_attr_group = {
> >  		if (kstrtoint(buf, 0, &burst) < 0)			\
> >  			return -EINVAL;					\
> >  									\
> > +		if (burst < 0)						\
> > +			burst = 0;					\
> > +									\
> >  		pdev->aer_info->ratelimit.burst = burst;		\
> >  									\
> >  		return count;						\
> 
> [Severity: Medium]
> This problem wasn't introduced by this patch, but shouldn't the companion
> aer_ratelimit_interval_attr() macro convert pdev->aer_info->ratelimit.interval
> back with jiffies_to_msecs() in name##_show() [1]?
> 
> drivers/pci/pcie/aer.c:aer_ratelimit_interval_attr() {
> 	static ssize_t							\
> 	name##_show(struct device *dev, struct device_attribute *attr,	\
> 					 char *buf)			\
> 	{								\
> 		struct pci_dev *pdev = to_pci_dev(dev);			\
> 									\
> 		return sysfs_emit(buf, "%d\n",				\
> 				  pdev->aer_info->ratelimit.interval);	\
> 	}								\
>     ...
> 		if (interval <= 0)					\
> 			interval = 0;					\
> 		else							\
> 			interval = msecs_to_jiffies(interval); 		\
> 									\
> 		pdev->aer_info->ratelimit.interval = interval;		\
> }
> 
> name##_store() converts the millisecond value into jiffies before storing it,
> so reading *_ratelimit_interval_ms back emits raw jiffies instead of
> milliseconds when HZ != 1000.
> 
> [1] https://sashiko.dev/#/bug/linux-3e0972eb-98a1-4365-b40e-82736dd85f13
> 

This is fixed in patch 3 of this set.

Thanks,
Yazen