From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794855861; b=GmVP4ZZv7QEMBlAIHVdstNuyTvIk4NAd7gjF3JsvMOgFKMJ0jBby9Xubku+ELvXj4ENZ 7Qq9tXsTo6U0ej5EBsYu0/dj36G9W8dES61uPUddomixAKbI1PGxqtpkII4bAhKyEM3S8 4HQ3L+Z32tV9WJW8ojjpplJ21PBt7WpdbQDWOpoBuOfL9lDHpZJOfSxGkCIAB5blkqLKe XKcEvqz9A/Q+BRh0u2DI447Sn0O0qXKhJA5rn37cnu7rdkA70WekxxYRj9MbW0Fx4aprs h+1bfTjyn3g/MdU6g1EqpDVCpxiSYyITb2ZENbGhZyb/HPYvzaYppsHx8Q3KQX2zPIw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794855861; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=WvOfbKHC1YhEa2QpW290x7cG/RSkj9nU3s9Pf1uScWc=; b=F7+x5k31s5nATmOA3xLNuTEFzGyTKfmXR7733eIjM9CXS7ifmMq121GO58UeRetHd2ow tfsN2RaeZFxMoRfjO2JkMSVF8owe+npReLLAMJFO52jU6WUvQiS6d9xOZppvJOf2Y2LWl Z1ppccz1DOhs+UBBsovqBZZWMhgtc2cvDxfwLhwnTy2GJYKi07ppfvgGsGNbaYo1PkKag E67MoU/r5i74Uu8yS/cXfO+JQ9J+/+OJ941k2uuUhPTyaGuc7aUkApmNFWfQ0wsGGDK3x g3VICO/IiHurcb45hi+kdRaZz+11CYztgmm9zl+iZD7E1L1xdLAJLFlGtMQ/8tYcw5w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=cV6xCUYW; arc=none smtp.remote-ip=209.85.160.171 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCA4606A323 for ; Mon, 16 Nov 2026 19:04:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DBCA4606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=cV6xCUYW Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-53664b4860bso48830251cf.1 for ; Mon, 16 Nov 2026 11:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794855859; x=1795460659; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WvOfbKHC1YhEa2QpW290x7cG/RSkj9nU3s9Pf1uScWc=; b=cV6xCUYW6Nj32ATgj9pR3hPHUcXMAswfWFmbofUn9Kj8O2h0vBxKz+gKkblkAcoZs4 3Sksf2uZJcrqFHnWfbGA31BNzwsf2S1dv95GJqgZVMfFGYLSB6zg6g2Fr+yuwov/in3t kzMGwphN2MWZmbFV+wYJtbSpA7Il47XDSpoenMocuugAiDnZMkgQe82N6D/LNCvFdxrw g4Vs+tRlvNQP2aXotTXnhkPG5j8fWm0uVGtEmoX6U112LRHDjo2Qmq5iAcSLMow6gR3a CP6w8W/FgL6u2p7O81zc788TpdcCz8lIWVKQDNRHCpvZKfTuZAAb/gE598LmoW33C074 z1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794855859; x=1795460659; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WvOfbKHC1YhEa2QpW290x7cG/RSkj9nU3s9Pf1uScWc=; b=XYJXOvXxkJcRBH5+5OiA9aAew3uIb4kZ5NnpLi6/fAoXOwG7Fl6zBVOPsKixlobXDK gmhqEriv65pCWXks9j/BxeSb0NJISgmDkxrK5s6Q2D4OlnAQPX6l/A1rPcNB8zf9Rguh FNkhkpIjzsWYtHXbqF/UrgmwWXvHGXjsf2UeJFYHPJ5B2JJf5WHWt8UmaPAbcQ0DWypj l1E4tX5IwDTdjkEI2oLCw/RPAp6eT2cCaWmSIgI7wY82WH3Ll37CanlIK6Eq11Oliuo3 l1PtAsctSBY5R96AGChNJhPEb3fD5s1NFLros8mgw/1oqC6yJzKWAgkTtcYui29ldLdm ZntA== X-Forwarded-Encrypted: i=1; AL+hErHrQFDewIpmlblddjg7y5GUYWcdJTFeoz8biuthsKgmZ7RENcZSKzq3/sco2i2zTUPbfBUAu077hkk=@vger.kernel.org X-Gm-Message-State: APuU4Z+2+A3JrpKt8ipY6wfADuDHcUKAAIxnxTYlhpMiHf4nzkPxYnPh S+218UuI/t2DDkA855KLKC4eeFdEdNWY14T0ciz9772QBsAj/L/t4W99UGQeciBmUeQ= X-Gm-Gg: AYBFou3k532nyvx3vM7HyzY3fUc+dhC8UwljBgInrK2w4YcIChB+wmHMghF4d2nShs7 f2FUtvEAmqVH1pMNKwM7LJCD0o458mZOckole5e1VNagfq8bn5BVPgxu+bum2E9kZw4rUxF73ks VxibVd806/EuMguSy5sOUfDEvBpZpSamJ7O8kKJe7Kgxaz/dYDb+vTa/buPRBCX8SHje2ycUfiz VD6AUv8+aY0/ldOqo2DwO/1zjSQEiCwuUfve+51AMHpbK+Cqp/2Q02yN5FHeSaF7RSDbU5NSLwg k34HmLa6b2bPzHAWQc6cIpdw8nFHcR6EGWEAkDdEhNCHkQOGPYSv/DDmintEllTCcC6R7kA4RdP QEHKg7bYsi3fyuKBNZQQjCih+yuyUAVKTkRLPiPGC3pvXUVvawsiR/E19KlZnxZ+ep/i8AHvgv8 c4UZ1T7dQVsLCMY6/aZri4S2y0/r6pG+8WX1ZjMUU9HGrJFh5sgQUGYhkBISmv0DpQOce681Dfh aY9NnJNiJkmx8v98HU2qJJ0mfaYhZKKLSst6IyihTgIx6uvJFNtGmdxr8lVRnYFU9Jkzc6grWSc 1lhq2A== X-Received: by 2002:a05:622a:124b:b0:536:9140:e2be with SMTP id d75a77b69052e-55ac948cc41mr174359441cf.74.1794855858824; Mon, 16 Nov 2026 11:04:18 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-55ad1b13917sm87667361cf.29.2026.11.16.11.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 11:04:17 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xT201-0000000AFsj-03Yl; Mon, 16 Nov 2026 15:04:17 -0400 Date: Mon, 16 Nov 2026 15:04:17 -0400 From: Jason Gunthorpe To: Kameron Carr Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 18/19] PCI: Replace untrusted state with device trust Message-ID: <20261116190417.GD2299285@ziepe.ca> References: <20261109-device-trust-core-v2-0-3b12d9a9f861@nvidia.com> <20261109-device-trust-core-v2-18-3b12d9a9f861@nvidia.com> <193e4130-9c2f-4a0f-b218-f5fcf0b3d508@linux.microsoft.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <193e4130-9c2f-4a0f-b218-f5fcf0b3d508@linux.microsoft.com> On Mon, Nov 16, 2026 at 10:46:25AM -0800, Kameron Carr wrote: > > @@ -1738,24 +1738,24 @@ static void set_pcie_cxl(struct pci_dev *dev) > > > > } > > > > -static void set_pcie_untrusted(struct pci_dev *dev) > > +static void pci_set_default_trust_policy(struct pci_dev *dev) > > { > > - struct pci_dev *parent = pci_upstream_bridge(dev); > > + struct pci_dev *parent = pci_physfn(dev); > > + > > + if (parent == dev) > > + parent = pci_upstream_bridge(dev); > > > > if (!parent) > > return; > > Hi Leon, > > The default policy here works for physical hierarchies, but there's no > opportunity for a paravirtual host bridge to participate in the trust > resolution when the host bridge driver itself knows the appropriate > trust level for a device. HW doesn't really "know" the trust level, it can suggest a default but the kernel command line and userspace should always be able to override it. > My scenario is pci-hyperv in a confidential VM with a paravisor. The > paravisor is inside the guest's trust boundary and owns TDISP. It locks, > attests and accepts the device, then answers a VMBus query describing > which BAR ranges are private and whether the device's DMA may target > private memory. Before a driver can bind pci-hyperv has to: Sounds like a user in such an environment just wouldn't use the trust level mechanism at all. What use do you see for enabling trust level but having all the devices unattestable and accepted already? Your bigger issue is the below: > - query the paravisor, > - refuse to operate the device if the query failed or if the response > is invalid, > - decide whether the device may operate. > > The modular host bridge driver in this scenario needs a hook to be able > to participate in trust resolution. > > I'm also looking for the right place to setup MMIO and configure DMA > in my scenario. Let me know if you have guidance. Well, you are very far outside what Linux expects for a CC flow, and these special requests conflict with the arch code flows we need to have. So, I don't know. Maybe somewhere in the arch code hyperv can hook and say the device is special? You'll have to see when we get more of the CC stuff layed out. Though, FWIW, I don't like it at all as a model. Denying the tenant the ability to directly attest the HW is far away from what I'd consider as necessary for CC. Jason