Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lukas Wunner <lukas@wunner.de>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Oliver O'Halloran <oohall@gmail.com>, Len Brown <lenb@kernel.org>,
	linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] PCI/DPC: Decide DPC ownership with host_bridge->native_dpc
Date: Wed, 18 Nov 2026 18:10:42 -0600	[thread overview]
Message-ID: <20261119001042.GA759430@bhelgaas> (raw)
In-Reply-To: <20261118181718.3907441-1-sathyanarayanan.kuppuswamy@linux.intel.com>

On Wed, Nov 18, 2026 at 10:17:12AM -0800, Kuppuswamy Sathyanarayanan wrote:
> This series makes host_bridge->native_dpc the single decider for whether
> Linux uses DPC, as Bjorn asked during the review of "Simplify PCIe native
> ownership".
> 
>   https://lore.kernel.org/r/20261001221408.GA2731929@bhelgaas
> 
> Today the DPC service binds on host_bridge->native_aer, AER availability
> and "pcie_ports=dpc-native".  host_bridge->native_dpc is only consulted
> by pci_dpc_recovered().  After this series, native_dpc is the end result
> of everything that decides DPC ownership, and portdrv binds the DPC
> service on it.
> 
> Patches 1-2 are the two DPC patches from v2 of Lukas's "Error reporting
> for AER-incapable devices", which are included here directly.
> 
>   https://lore.kernel.org/r/34c9ee153876bac953135b4518035194b7c07c6c.1794997749.git.lukas@wunner.de
>   https://lore.kernel.org/r/58d8a99cc6c2ecba6dadc450ecb4501d47816732.1794997749.git.lukas@wunner.de
> 
> Patch 1 keeps the DPC driver from accessing a non-existent AER
> capability.
> 
> Patch 2 drops the AER ownership check from dpc_probe(), so DPC also
> works on ports without an AER capability.
> 
> Patch 3 builds EDR whenever DPC is enabled on ACPI, so CONFIG_PCIE_EDR
> is no longer a separate knob in deciding whether to request DPC control.
> 
> Patch 4 stops requiring pci_aer_available() to bind the DPC service,
> since the DPC driver does not depend on MSI or on the AER driver.
> 
> Patch 5 requests DPC control only together with AER control, as PCI
> Firmware r3.3, sec 4.5.2.4, requires.
> 
> Patch 6 binds the DPC service on host_bridge->native_dpc and logs a
> message when the OS assumes DPC control that _OSC did not grant.
> 
> Changes since v2:
> 
>   - Pick up v2 of Lukas's two DPC patches.  Patch 1 now uses the AER
>     capability to find the error severity when the port has one.
> 
>   - Keep CONFIG_PCIE_EDR as a hidden option instead of removing it, and
>     remove the pci_dpc_recovered() check that becomes dead (Yazen).
> 
>   - Fold the PCI Firmware spec reference into the existing comment in
>     calculate_control() (Yazen).
> 
>   - Shorten the comment in acpi_pci_root_create() (Yazen).
> 
>   - Rebase on v7.4-rc1 and add Reviewed-by and Acked-by tags.
> 
> v2: https://lore.kernel.org/r/20261020181924.3003553-1-sathyanarayanan.kuppuswamy@linux.intel.com
> v1: https://lore.kernel.org/r/20261007165840.1604136-1-sathyanarayanan.kuppuswamy@linux.intel.com
> 
> Kuppuswamy Sathyanarayanan (4):
>   PCI/EDR: Build EDR whenever DPC is enabled on ACPI
>   PCI/portdrv: Don't require AER to bind DPC service
>   PCI/ACPI: Request DPC control only together with AER control
>   PCI/portdrv: Bind DPC service based on host_bridge->native_dpc
> 
> Lukas Wunner (2):
>   PCI/DPC: Avoid access to non-existent AER capability
>   PCI/DPC: Reinstate support for AER-incapable ports
> 
>  drivers/acpi/pci_root.c    | 19 +++++++++++--
>  drivers/pci/pcie/Kconfig   |  8 +-----
>  drivers/pci/pcie/dpc.c     | 58 +++++++++++++++++++++-----------------
>  drivers/pci/pcie/portdrv.c |  7 +----
>  4 files changed, 51 insertions(+), 41 deletions(-)

Applied to pci/aer for v7.5, thank you!

B4 seems to collect historical things, e.g., Yazen's reviewed-by and
another Fixes: tag on "PCI/DPC: Reinstate support for AER-incapable
ports".  I *guess* that's all great, but I didn't dig out where they
originally came from.  I don't see them in the v3 thread on lore
(https://lore.kernel.org/all/20261118181718.3907441-1-sathyanarayanan.kuppuswamy@linux.intel.com/),
so they must be from a previous posting.

      parent reply	other threads:[~2026-11-19  0:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:17 [PATCH v3 0/6] PCI/DPC: Decide DPC ownership with host_bridge->native_dpc Kuppuswamy Sathyanarayanan
2026-11-18 18:17 ` [PATCH v3 1/6] PCI/DPC: Avoid access to non-existent AER capability Kuppuswamy Sathyanarayanan
2026-11-18 18:24   ` sashiko-bot
2026-11-18 18:17 ` [PATCH v3 2/6] PCI/DPC: Reinstate support for AER-incapable ports Kuppuswamy Sathyanarayanan
2026-11-18 18:24   ` sashiko-bot
2026-11-18 18:17 ` [PATCH v3 3/6] PCI/EDR: Build EDR whenever DPC is enabled on ACPI Kuppuswamy Sathyanarayanan
2026-11-18 18:24   ` sashiko-bot
2026-11-18 18:17 ` [PATCH v3 4/6] PCI/portdrv: Don't require AER to bind DPC service Kuppuswamy Sathyanarayanan
2026-11-18 18:26   ` sashiko-bot
2026-11-18 18:17 ` [PATCH v3 5/6] PCI/ACPI: Request DPC control only together with AER control Kuppuswamy Sathyanarayanan
2026-11-18 18:24   ` sashiko-bot
2026-11-18 18:17 ` [PATCH v3 6/6] PCI/portdrv: Bind DPC service based on host_bridge->native_dpc Kuppuswamy Sathyanarayanan
2026-11-18 18:24   ` sashiko-bot
2026-11-19  0:10 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119001042.GA759430@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=oohall@gmail.com \
    --cc=rafael@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox