From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795118155; b=LowPb0yTD9HxEUO0/LXQYmVWQcaCdnDpOzzyjkdf6ieA6+y2iReeSyoS23ifRY5Dja7i BlRmjHm2bhwHbRpax1r8Ix9VS36r9KrIsXokxRcsnDMc6aFk+0eW5eFgCSn3gZJ0XFIvu nzzmjscZfWgh0skU9TdrRuUzfuhIL2MijUbYDdapMsuOwF0POL91asbKd3b9zRN4p1Y5i cYOBHimA+nyCkU+Ykb95yXgGAFcmx1avdSrWsImnH9FSJ3JNHfbbJKrZ9T7/OEy1FtWR2 DJlo31kWOTgKwPMjQd5OGTyDSDetvQkm6lBdJMagEuAv0muc/akU8mHFlRqpHJoh2wA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795118155; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=MVqqWDbhp5V3jEmBzisBCg1Pcm0LP8OpokoRgASxL/k=; b=YIXM1dC3L36Zu0mhuJMJGJdhNJdpcsc5lStZbfEAFnQBdkm/IsVEQ8X5OlP2HzKPofbw ZQrq9l9Z124fTkYRibAyMH3IjN27C013MxTPgHaW/hb0Re/PuNhjUuADBOI1ns0h5Dn4S y83Zo/vl3CkXJbQTp6P4ix2rbI5OlATg5AhEUu/956DClZ02nhmmKLJPQuhl4dT6C4KMa r5AI0NSSfXxhD8cKtR9ojSX8EYMgOFKE0yPQhF24d8QEhf3dnRcLQAIh28DiHVQq40CLZ 731aDUts+6yQNLKmauQwZFXJsm8qvTC0Vx6LrnWV5x/gyZ7mR8e3Lo5vv4uV05g6W4A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="YtwS/WSZ"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A25B4606A324 for ; Thu, 19 Nov 2026 19:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YtwS/WSZ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CE0B1F000C4; Thu, 19 Nov 2026 19:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795118155; bh=MVqqWDbhp5V3jEmBzisBCg1Pcm0LP8OpokoRgASxL/k=; h=Date:From:To:Cc:Subject:In-Reply-To; b=YtwS/WSZ8ooDiRvR16KU3ttTNtCTGD3fy1Nl5VBvxrG0BSiiuiYdqWNphd1bYcpjG abMvNwEjpkyRJatY9ovhXYp0YWx4fPnGFm1/oJm0VvwBN3GrXSMbAgXNqs9nNZpwc2 RGwoBCOg5lxCCxXmlvx9ZIQe+pO0AxMRDgMsaK0pacY+6fDcJMW4VAqacHhDBmDtPb imczBwNL2Fphm93K7ShSLXdKAOyMj6eiRESLccR6W7RPdbAjncQh/dZlbjwumPtK9P 7nW5LC+84mdNLbm2GGYOOnIGgQb6uBCBW83aj7djBRNkcDXsxGpYZVvan/9SyzdiJj DUduflOeCkZTA== Date: Thu, 19 Nov 2026 13:55:53 -0600 From: Bjorn Helgaas To: Mario Limonciello Cc: Bjorn Helgaas , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Lijo Lazar , linux-pci@vger.kernel.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v8 1/3] PCI: Cache bridge firmware secondary bus number Message-ID: <20261119195553.GA835692@bhelgaas> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261119-vfct-regression-v8-v8-1-12463194e457@amd.com> On Thu, Nov 19, 2026 at 01:21:19PM -0600, Mario Limonciello wrote: > Drivers such as amdgpu and radeon need the bus number firmware assigned > to a device to match it against firmware tables like VFCT. The PCI core > may renumber buses (e.g. with pci=realloc), after which the runtime > number no longer reflects what firmware programmed. > > Record the bridge's secondary bus number in its struct pci_dev when > pci_read_bridge_windows() reads the bus number register. This happens > once, when the bridge is first enumerated and before any renumbering, > so the value is what firmware left at FW/OS handoff. Devices behind the > bridge can then retrieve their firmware bus number via their upstream > bridge. > > Signed-off-by: Mario Limonciello Acked-by: Bjorn Helgaas I assume you'll merge via DRM? > --- > drivers/pci/probe.c | 1 + > include/linux/pci.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 9a178e0e5f7f4..89a7c52ac3e5b 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -513,6 +513,7 @@ static void pci_read_bridge_windows(struct pci_dev *bridge) > res.flags = IORESOURCE_BUS; > res.start = FIELD_GET(PCI_SECONDARY_BUS_MASK, buses); > res.end = FIELD_GET(PCI_SUBORDINATE_BUS_MASK, buses); > + bridge->fw_sec_busnr = res.start; > pci_info(bridge, "PCI bridge to %pR%s\n", &res, > bridge->transparent ? " (subtractive decode)" : ""); > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index aa3765a20a96c..4c1b1e557a607 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -363,6 +363,8 @@ struct pci_dev { > struct pci_slot *slot; /* Physical slot this device is in */ > > unsigned int devfn; /* Encoded device & function index */ > + /* Bridge secondary bus number at FW/OS handoff */ > + unsigned char fw_sec_busnr; > unsigned short vendor; > unsigned short device; > unsigned short subsystem_vendor; > > -- > 2.43.0 >