From: Arnd Bergmann <arnd@arndb.de>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Robert Richter <robert.richter@caviumnetworks.com>,
Robert Richter <rric@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Will Deacon <Will.Deacon@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Sunil Goutham <sgoutham@cavium.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] arm64, defconfig: Enable PCI
Date: Thu, 25 Sep 2014 12:45:20 +0200 [thread overview]
Message-ID: <21218217.YUcdQIZ4A8@wuerfel> (raw)
In-Reply-To: <20140925093545.GE10390@e104818-lin.cambridge.arm.com>
On Thursday 25 September 2014 10:35:45 Catalin Marinas wrote:
> On Wed, Sep 24, 2014 at 07:40:18PM +0100, Arnd Bergmann wrote:
> > On Wednesday 24 September 2014 18:10:48 Catalin Marinas wrote:
> > > > The intention is not to have a second definition, instead this should
> > > > enable the default value just for arm64. Thus I put it to
> > > > arch/arm64/Kconfig. Otherwise it would be enabled per default on all
> > > > archs.
> >
> > I don't think other architectures actually see the PCI symbol that is
> > defined in the arm64 Kconfig file, but I might be wrong.
>
> Other archs wouldn't see the symbols in arch/arm64/Kconfig.
Ok.
> > > > We could have used select in config ARM64, but I tried to avoid using
> > > > select due to the dependency issue and instead implement this with
> > > > default-y/depends-on. Doing so it can be manually disabled too.
> >
> > How about adding a new symbol like
> >
> > config ARM64_PCI
> > def_bool PCI
> > select PCI_MSI
>
> How is this different from just selecting PCI_MSI in config PCI in
> arch/arm64/Kconfig? I don't see what another symbol brings.
That suggestion was just in case I was wrong above. If the symbol
is indeed hidden elsewhere, we don't need it.
Arnd
next prev parent reply other threads:[~2014-09-25 10:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 15:37 [PATCH 0/6] pci, thunder: Add Cavium Thunder PCIe host controller Robert Richter
2014-09-24 15:37 ` [PATCH 1/6] pci, thunder: Add support for " Robert Richter
2014-09-24 16:12 ` Arnd Bergmann
2014-09-24 16:49 ` Will Deacon
2014-09-30 9:14 ` Sunil Kovvuri
2014-09-24 15:37 ` [PATCH 2/6] GICv3: Add ITS entry to THUNDER dts Robert Richter
2015-06-25 23:19 ` Chalamarla, Tirumalesh
2015-06-26 9:00 ` Marc Zyngier
2014-09-24 15:37 ` [PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings Robert Richter
2014-09-24 16:06 ` Arnd Bergmann
2014-09-24 18:04 ` Sunil Kovvuri
2014-09-24 18:34 ` Arnd Bergmann
2014-09-24 19:07 ` Sunil Kovvuri
2014-09-25 7:31 ` Arnd Bergmann
2014-09-25 16:16 ` Bjorn Helgaas
2014-09-25 19:26 ` Arnd Bergmann
2014-09-25 20:10 ` Bjorn Helgaas
2014-09-25 20:22 ` Arnd Bergmann
2014-09-25 20:49 ` Bjorn Helgaas
2014-09-26 18:26 ` Rob Herring
2014-09-30 9:11 ` Sunil Kovvuri
2014-10-07 14:27 ` Robert Richter
2014-10-07 15:01 ` Liviu Dudau
2014-10-08 8:49 ` Robert Richter
2014-10-08 16:44 ` Liviu Dudau
2014-10-09 6:23 ` Robert Richter
2014-09-24 15:37 ` [PATCH 4/6] pci, thunder: Document " Robert Richter
2014-09-24 15:37 ` [PATCH 5/6] arm64, defconfig: Enable PCI Robert Richter
2014-09-24 16:14 ` Arnd Bergmann
2014-09-24 16:26 ` Robert Richter
2014-09-24 17:10 ` Catalin Marinas
2014-09-24 18:40 ` Arnd Bergmann
2014-09-25 9:35 ` Catalin Marinas
2014-09-25 10:45 ` Arnd Bergmann [this message]
2014-09-24 15:37 ` [PATCH 6/6] pci, thunder: Enable Cavium Thunder PCIe host controller Robert Richter
2014-09-24 17:12 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21218217.YUcdQIZ4A8@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).