* Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse @ 2014-02-23 23:33 Jingoo Han 2014-02-24 21:38 ` Bjorn Helgaas 0 siblings, 1 reply; 6+ messages in thread From: Jingoo Han @ 2014-02-23 23:33 UTC (permalink / raw) To: Thomas Gleixner, LKML Cc: Ingo Molnar, Peter Zijlstra, Bjorn Helgaas, Mohit Kumar, pci, Jingoo Han T24gTW9uZGF5LCBGZWJydWFyeSAyNCwgMjAxNCA2OjQwIEFNLCBUaG9tYXMgR2xlaXhuZXIgd3Jv dGU6DQo+IA0KPiBUaGVyZSBpcyBubyByZWFzb24gdG8gY2FyZSBhYm91dCBpcnFfZGVzYyBpbiB0 aGF0IGNvbnRleHQsIGVzY3BlY2lhbGx5DQo+IGFzIGlycV9kYXRhIGZvciB0aGF0IGludGVycnVw dCBpcyByZXRyaWV2ZWQgYXMgd2VsbC4NCj4gDQo+IFVzZSB0aGUgcHJvcGVyIGFjY2Vzc29yIGZv ciB0aGUgbXNpIGRlc2NyaXB0b3INCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBHbGVpeG5l ciA8dGdseEBsaW51dHJvbml4LmRlPg0KPiBDYzogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29v Z2xlLmNvbT4NCj4gQ2M6IEppbmdvbyBIYW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+DQo+IENjOiBN b2hpdCBLdW1hciA8bW9oaXQua3VtYXJAc3QuY29tPg0KPiBDYzogcGNpIDxsaW51eC1wY2lAdmdl ci5rZXJuZWwub3JnPg0KDQpBY2tlZC1ieTogSmluZ29vIEhhbiA8amcxLmhhbkBzYW1zdW5nLmNv bT4NCg0KQSBmZXcgZGF5cyBhZ28sIEkgbm90aWNlZCB0aGF0IGlycV9kYXRhX2dldF9tc2koKSBj YW4gYmUgdXNlZC4NCkhvd2V2ZXIsIEkgZGlkIG5vdCBzdWJtaXQgdGhlIHNhbWUgcGF0Y2guIEkg cmVhbGx5IGFwcHJlY2lhdGUNCnlvdXIgcGF0Y2guIDotKQ0KDQpCZXN0IHJlZ2FyZHMsDQpKaW5n b28gSGFuDQoNCj4gLS0tDQo+ICBkcml2ZXJzL3BjaS9ob3N0L3BjaWUtZGVzaWdud2FyZS5jIHwg ICAgNCArLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25z KC0pDQo+IA0KPiBJbmRleDogdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMN Cj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KPiAtLS0gdGlwLm9yaWcvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2ln bndhcmUuYw0KPiArKysgdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMNCj4g QEAgLTI5NCwxNCArMjk0LDEyIEBAIG5vX3ZhbGlkX2lycToNCj4gIHN0YXRpYyB2b2lkIGNsZWFy X2lycSh1bnNpZ25lZCBpbnQgaXJxKQ0KPiAgew0KPiAgCXVuc2lnbmVkIGludCBwb3MsIG52ZWM7 DQo+IC0Jc3RydWN0IGlycV9kZXNjICpkZXNjOw0KPiAgCXN0cnVjdCBtc2lfZGVzYyAqbXNpOw0K PiAgCXN0cnVjdCBwY2llX3BvcnQgKnBwOw0KPiAgCXN0cnVjdCBpcnFfZGF0YSAqZGF0YSA9IGly cV9nZXRfaXJxX2RhdGEoaXJxKTsNCj4gDQo+ICAJLyogZ2V0IHRoZSBwb3J0IHN0cnVjdHVyZSAq Lw0KPiAtCWRlc2MgPSBpcnFfdG9fZGVzYyhpcnEpOw0KPiAtCW1zaSA9IGlycV9kZXNjX2dldF9t c2lfZGVzYyhkZXNjKTsNCj4gKwltc2kgPSBpcnFfZGF0YV9nZXRfbXNpKGRhdGEpOw0KPiAgCXBw ID0gc3lzX3RvX3BjaWUobXNpLT5kZXYtPmJ1cy0+c3lzZGF0YSk7DQo+ICAJaWYgKCFwcCkgew0K PiAgCQlCVUcoKTs= ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse 2014-02-23 23:33 [patch 07/26] pci: pcie-designware: Remove irq_desc abuse Jingoo Han @ 2014-02-24 21:38 ` Bjorn Helgaas 2014-02-24 22:06 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2014-02-24 21:38 UTC (permalink / raw) To: Jingoo Han Cc: Thomas Gleixner, LKML, Ingo Molnar, Peter Zijlstra, Mohit Kumar, pci On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote: > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: >> >> There is no reason to care about irq_desc in that context, escpecially >> as irq_data for that interrupt is retrieved as well. >> >> Use the proper accessor for the msi descriptor >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Cc: Jingoo Han <jg1.han@samsung.com> >> Cc: Mohit Kumar <mohit.kumar@st.com> >> Cc: pci <linux-pci@vger.kernel.org> > > Acked-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. Bjorn > A few days ago, I noticed that irq_data_get_msi() can be used. > However, I did not submit the same patch. I really appreciate > your patch. :-) > > Best regards, > Jingoo Han > >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> Index: tip/drivers/pci/host/pcie-designware.c >> =================================================================== >> --- tip.orig/drivers/pci/host/pcie-designware.c >> +++ tip/drivers/pci/host/pcie-designware.c >> @@ -294,14 +294,12 @@ no_valid_irq: >> static void clear_irq(unsigned int irq) >> { >> unsigned int pos, nvec; >> - struct irq_desc *desc; >> struct msi_desc *msi; >> struct pcie_port *pp; >> struct irq_data *data = irq_get_irq_data(irq); >> >> /* get the port structure */ >> - desc = irq_to_desc(irq); >> - msi = irq_desc_get_msi_desc(desc); >> + msi = irq_data_get_msi(data); >> pp = sys_to_pcie(msi->dev->bus->sysdata); >> if (!pp) { >> BUG(); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse 2014-02-24 21:38 ` Bjorn Helgaas @ 2014-02-24 22:06 ` Thomas Gleixner 2014-02-24 23:03 ` Bjorn Helgaas 0 siblings, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2014-02-24 22:06 UTC (permalink / raw) To: Bjorn Helgaas Cc: Jingoo Han, LKML, Ingo Molnar, Peter Zijlstra, Mohit Kumar, pci On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote: > > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: > >> > >> There is no reason to care about irq_desc in that context, escpecially > >> as irq_data for that interrupt is retrieved as well. > >> > >> Use the proper accessor for the msi descriptor > >> > >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > >> Cc: Bjorn Helgaas <bhelgaas@google.com> > >> Cc: Jingoo Han <jg1.han@samsung.com> > >> Cc: Mohit Kumar <mohit.kumar@st.com> > >> Cc: pci <linux-pci@vger.kernel.org> > > > > Acked-by: Jingoo Han <jg1.han@samsung.com> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > Thomas, I assume you'll merge this along with the rest of your series. > I don't have any pending changes in this area. I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse 2014-02-24 22:06 ` Thomas Gleixner @ 2014-02-24 23:03 ` Bjorn Helgaas 2014-02-24 23:15 ` Thomas Gleixner 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2014-02-24 23:03 UTC (permalink / raw) To: Thomas Gleixner Cc: Jingoo Han, LKML, Ingo Molnar, Peter Zijlstra, Mohit Kumar, pci On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Mon, 24 Feb 2014, Bjorn Helgaas wrote: >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote: >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: >> >> >> >> There is no reason to care about irq_desc in that context, escpecially >> >> as irq_data for that interrupt is retrieved as well. >> >> >> >> Use the proper accessor for the msi descriptor >> >> >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> >> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> >> Cc: Jingoo Han <jg1.han@samsung.com> >> >> Cc: Mohit Kumar <mohit.kumar@st.com> >> >> Cc: pci <linux-pci@vger.kernel.org> >> > >> > Acked-by: Jingoo Han <jg1.han@samsung.com> >> >> Acked-by: Bjorn Helgaas <bhelgaas@google.com> >> >> Thomas, I assume you'll merge this along with the rest of your series. >> I don't have any pending changes in this area. > > I can do, but it does not depend on anything else, so you can pick it > up as well. Either way is fine. I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter. What's the recommended practice? Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse 2014-02-24 23:03 ` Bjorn Helgaas @ 2014-02-24 23:15 ` Thomas Gleixner 0 siblings, 0 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-02-24 23:15 UTC (permalink / raw) To: Bjorn Helgaas Cc: Jingoo Han, LKML, Ingo Molnar, Peter Zijlstra, Mohit Kumar, pci On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > > On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@samsung.com> wrote: > >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: > >> >> > >> >> There is no reason to care about irq_desc in that context, escpecially > >> >> as irq_data for that interrupt is retrieved as well. > >> >> > >> >> Use the proper accessor for the msi descriptor > >> >> > >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > >> >> Cc: Bjorn Helgaas <bhelgaas@google.com> > >> >> Cc: Jingoo Han <jg1.han@samsung.com> > >> >> Cc: Mohit Kumar <mohit.kumar@st.com> > >> >> Cc: pci <linux-pci@vger.kernel.org> > >> > > >> > Acked-by: Jingoo Han <jg1.han@samsung.com> > >> > >> Acked-by: Bjorn Helgaas <bhelgaas@google.com> > >> > >> Thomas, I assume you'll merge this along with the rest of your series. > >> I don't have any pending changes in this area. > > > > I can do, but it does not depend on anything else, so you can pick it > > up as well. Either way is fine. > > I never know what to do with these. I suggested that you pick it up > so the whole series would be together, because I assumed it would make > more sense in the git history to have all these similar changes > grouped together. But maybe that really doesn't matter. > > What's the recommended practice? Dunno. There is no rule. I'll merge it up with the rest of the lot. Thanks, tglx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20140223212703.511977310@linutronix.de>]
* [patch 07/26] pci: pcie-designware: Remove irq_desc abuse [not found] <20140223212703.511977310@linutronix.de> @ 2014-02-23 21:40 ` Thomas Gleixner 0 siblings, 0 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-02-23 21:40 UTC (permalink / raw) To: LKML Cc: Ingo Molnar, Peter Zijlstra, Bjorn Helgaas, Jingoo Han, Mohit Kumar, pci There is no reason to care about irq_desc in that context, escpecially as irq_data for that interrupt is retrieved as well. Use the proper accessor for the msi descriptor Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Jingoo Han <jg1.han@samsung.com> Cc: Mohit Kumar <mohit.kumar@st.com> Cc: pci <linux-pci@vger.kernel.org> --- drivers/pci/host/pcie-designware.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: tip/drivers/pci/host/pcie-designware.c =================================================================== --- tip.orig/drivers/pci/host/pcie-designware.c +++ tip/drivers/pci/host/pcie-designware.c @@ -294,14 +294,12 @@ no_valid_irq: static void clear_irq(unsigned int irq) { unsigned int pos, nvec; - struct irq_desc *desc; struct msi_desc *msi; struct pcie_port *pp; struct irq_data *data = irq_get_irq_data(irq); /* get the port structure */ - desc = irq_to_desc(irq); - msi = irq_desc_get_msi_desc(desc); + msi = irq_data_get_msi(data); pp = sys_to_pcie(msi->dev->bus->sysdata); if (!pp) { BUG(); ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-24 23:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-23 23:33 [patch 07/26] pci: pcie-designware: Remove irq_desc abuse Jingoo Han
2014-02-24 21:38 ` Bjorn Helgaas
2014-02-24 22:06 ` Thomas Gleixner
2014-02-24 23:03 ` Bjorn Helgaas
2014-02-24 23:15 ` Thomas Gleixner
[not found] <20140223212703.511977310@linutronix.de>
2014-02-23 21:40 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).