Re: [PATCH v3 0/3] PCIe Enclosure LED Management

[stuart hayes <stuart.w.hayes@gmail.com>]

On 7/5/2024 7:54 AM, Mariusz Tkaczyk wrote:
> Patchset is named as PCIe Enclosure LED Management because it adds two features:
> - Native PCIe Enclosure Management (NPEM)
> - PCIe SSD Status LED Management (DSM)
> 
> Both are pattern oriented standards, they tell which "indication" should blink.
> It doesn't control physical LED or pattern visualization.
> 
> Overall, driver is simple but it was not simple to fit it into interfaces
> we have in kernel (We considered leds and enclosure interfaces). It reuses
> leds interface, this approach seems to be the best because:
> - leds are actively maintained, no new interface added.
> - leds do not require any extensions, enclosure needs to be adjusted first.
> 
> There are trade-offs:
> - "brightness" is the name of sysfs file to control led. It is not
>    natural to use brightness to set patterns, that is why multiple led
>    devices are created (one per indication);
> - Update of one led may affect other leds, led triggers may not work
>    as expected.
> 
> It was tested with _DSM but I do some minor updates after review.
> Stuart please retest.
> 

Works great for me, thank you!!