From: Daniel Almeida <daniel.almeida@collabora.com>
To: Fiona Behrens <me@kloenk.dev>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] rust: io: rename `io::Io` accessors
Date: Mon, 17 Feb 2025 18:36:52 -0300 [thread overview]
Message-ID: <2244CEBA-3AF2-4572-B32E-8BA9F86417C9@collabora.com> (raw)
In-Reply-To: <20250217-io-generic-rename-v1-1-06d97a9e3179@kloenk.dev>
Hi Fiona,
> On 17 Feb 2025, at 17:58, Fiona Behrens <me@kloenk.dev> wrote:
>
> Rename the I/O accessors provided by `Io` to encode the type as
> number instead of letter. This is in preparation for Port I/O support
> to use a trait for generic accessors.
>
> Add a `c_fn` argument to the accessor generation macro to translate
> between rust and C names.
>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/PIO.20support/near/499460541
> Signed-off-by: Fiona Behrens <me@kloenk.dev>
IMHO, the `writel` and `readl` nomenclature is extremely widespread, so it’s a bit confusing to see this renamed.
On the other hand, I do understand that such a change may be needed for ergonomic reasons when introducing
PIO, so I guess we will have to live with it :)
Acked-by: Daniel Almeida <daniel.almeida@collabora.com>
next prev parent reply other threads:[~2025-02-17 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 20:58 [PATCH] rust: io: rename `io::Io` accessors Fiona Behrens
2025-02-17 21:35 ` Danilo Krummrich
2025-02-17 21:36 ` Daniel Almeida [this message]
2025-02-17 21:59 ` Miguel Ojeda
2025-02-17 22:29 ` Danilo Krummrich
2025-02-18 7:57 ` Greg Kroah-Hartman
2025-02-22 13:54 ` Miguel Ojeda
2025-02-22 14:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2244CEBA-3AF2-4572-B32E-8BA9F86417C9@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox