From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03082EC09F for ; Sun, 17 May 2026 08:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779005388; cv=none; b=HaY/1vHe9ABscoPaMD43HD5vbddZSIQzTomOGDvMJTvsGc4EFyKf78htSSOhgdwNyD0eGP/fDlRmgN965ZoH6nuQKoNB2RVCxA3nTPqq0Dn3q5oF+AIHcDLVTvoGCALOO67FJriUuac+1ymkJ4vww7tDRcdQMJBBHWeuYfp147A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779005388; c=relaxed/simple; bh=kbwBJp1YaFiYMYBQ5HwtsOteGWjAla/XSzKeMhwGk5w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eqn9wf59xfBd8WngW7PBjOUvo7krkJpR8UGcn7oO8bD4ahwD0L38kRdCqM33u7J6+1gQ1dkIbj4/jJqqXfvRRGwi0aks6AQT1FYyPayqxe1KBi/e9gcWYWsYI1lrJnQRc673kkEZOM/tYeo3qc3v1/iZw/yBfkkcvWQ/boZ/wVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cXNv6QfN; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cXNv6QfN" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso16388215e9.1 for ; Sun, 17 May 2026 01:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779005385; x=1779610185; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QI5AguO9/rJalyHGNSvMkm5DR7zkmggq523vj4QHofA=; b=cXNv6QfNNKhCJ/GaC162/O/R/3rHvwJf1EI2oOAGvBamjyPtbFBN0S7+MS5F68gihU 31skrCVj5uU1F0YlhEOvpYLfPmQGUauj2L/VTeZlXd7a7gR23UV84bTrANwhB76orSV4 j/ViflO3SVA+PT6knPyaCuQIqNbWOeQXs2fXccNaTrlwHBgyFGbmyjPPuC8MjwgftILG TjhkkUOouqhP+brRA4TKQ38Pr+pFoc8Hv/GnzZ/sQB0PYa0J/hYATi29rS3OAfbqNBHO ojbqL8aAknzTq8y2lIqypy0Yc6e8a4p6e3/e1n0wPzTloCVGGKsnwf+qXEwqtteueOrL 7o1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779005385; x=1779610185; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QI5AguO9/rJalyHGNSvMkm5DR7zkmggq523vj4QHofA=; b=cK1Npui/yQZ/PC7CRj07V9W8tJZ2rvfhoE0tLSMNx7aTmzrfgVbkdEif1mmhk7hM6q UIGy2TSH46b3rukkRRljiRxUVIeDvLjewqdwifc4l+ZhIA8vlkGm2JG6NPE8L/Y6zd64 aR80F0PFXe+wPyKm4qB/eh9L9icKvY5ETbvyA4EdaXF9NCq818TDpd9UInOj/ZNy3oaa NzLYCnaamQCz7j8zT/cKpMxM8l3dhNuqpKJOyCi8ZtgkVxQ7YA35RU38ycR0VCzsKfn+ HO8I53uewKIx2xDlh60nbKdPcO/56fZ7qE4v0n9dyQ8IzMJoEbL5P1+4GOlLiGiY4S1c fX1A== X-Forwarded-Encrypted: i=1; AFNElJ8+SYPUIujWJ2RGToajAiGHnepv3MyVzx6kiGHplEIipiOH8tvep6ipXEqki2e4AX/rvyzmncubBKo=@vger.kernel.org X-Gm-Message-State: AOJu0YwBdqYu/LFAH6ICCqQ3uPG2HoIbJmeOlLwvKZkfjjyIujC4aXjG +v3RE9ioTPB0+oB7grYugWA3qZgBmS8q8znHV7SuTwou1g5nrQlE11/K X-Gm-Gg: Acq92OENo0h2BtQrVWtkfn5Z4M7KDQJ22WLRcbPD9V4JDXSLWVkNhWXbJ8+Ve/mo+ge Q+cQgMXzS3LaN/m0FMcbFe+KTfxhCEoSxvjwlfvweyrFgdxXwYBc1YuWedvPt43i4Wr2zOw1364 0kESA8g68wmoJJlRrwx9vP1hpgFt3Y/XZiIKztNu4FMxInWqN/2R15t4xXkmwU7SOkqSHbfhDzR ekmwpI/DLiSnt2s4R7S7nhe8x3r22LmGFSzvhP+b7KA9tq4IWneMCtHosa5s1ouY0cdtFIxKWEd J1yLYx2z4SGemN9Xl21ZRJ5KI4x306CnWH6p6hWUYEh70KFDFkGAunARKdz4NUuP8jg75Jtj/lI TrDRRDM3EjcgVYio7HqUmOxl5En25iWCt354WxK9rLOBCzhgZJMDrCbhLckyw/c1DX9NY1StcUs lMA1Ip10SxvwIGlcDPqCsKDeVMZ0AgbyPphXp0pbzHjGikcsPuSu6FAkkdGaAwoermB9lyrNWak 4TrSko/XwhRC8V0c3JcF63oisECHiyP3+0f2eHxUdsiKvb05RaBtuVTKw== X-Received: by 2002:a05:600c:4455:b0:48e:8dec:19ad with SMTP id 5b1f17b1804b1-48fe60ea94emr143018005e9.12.1779005384814; Sun, 17 May 2026 01:09:44 -0700 (PDT) Received: from ?IPV6:2003:df:bf18:1100:dd94:6a85:70a7:b48d? (p200300dfbf181100dd946a8570a7b48d.dip0.t-ipconnect.de. [2003:df:bf18:1100:dd94:6a85:70a7:b48d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0f72sm30335649f8f.25.2026.05.17.01.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2026 01:09:44 -0700 (PDT) Message-ID: <23e1bcba-da88-4cc6-83ca-b77bcdaa9d2c@gmail.com> Date: Sun, 17 May 2026 10:09:42 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/18] lib: rspdm: Support SPDM challenge To: alistair23@gmail.com, alistair@alistair23.me, linux-kernel@vger.kernel.org, lukas@wunner.de, Jonathan.Cameron@huawei.com, bhelgaas@google.com, rust-for-linux@vger.kernel.org, akpm@linux-foundation.org, linux-cxl@vger.kernel.org, djbw@kernel.org, linux-pci@vger.kernel.org Cc: alex.gaynor@gmail.com, wilfred.mallawa@wdc.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, aliceryhl@google.com, boqun.feng@gmail.com, a.hindborg@kernel.org, tmgross@umich.edu, ojeda@kernel.org References: <20260508031710.514574-1-alistair.francis@wdc.com> <20260508031710.514574-19-alistair.francis@wdc.com> Content-Language: de-AT-frami From: Dirk Behme In-Reply-To: <20260508031710.514574-19-alistair.francis@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08.05.26 05:17, alistair23@gmail.com wrote: > From: Alistair Francis > > Support the CHALLENGE SPDM command. > > Signed-off-by: Alistair Francis > --- ... > +impl Validate<&mut Unvalidated>> for &mut ChallengeRsp { > + type Err = Error; > + > + fn validate(unvalidated: &mut Unvalidated>) -> Result { > + let raw = unvalidated.raw_mut(); > + if raw.len() < mem::size_of::() { > + return Err(EINVAL); > + } > + > + let ptr = raw.as_mut_ptr(); > + // CAST: `ChallengeRsp` only contains integers and has `repr(C)`. > + let ptr = ptr.cast::(); > + // SAFETY: `ptr` came from a reference and the cast above is valid. > + let rsp: &mut ChallengeRsp = unsafe { &mut *ptr }; > + > + Ok(rsp) > + } > +} Just as reference, there is some discussion about this in https://lore.kernel.org/rust-for-linux/2026051610-flint-compound-810f@gregkh/ Dirk