linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
	wim.ten.have@oracle.com, linux-arm-msm@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port
Date: Wed, 12 Jul 2017 09:07:14 -0400	[thread overview]
Message-ID: <25b6bbf6-20b5-dfc8-c92a-268c07fa1f98@codeaurora.org> (raw)
In-Reply-To: <20170711203957.GB14614@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

On 7/11/2017 4:39 PM, Bjorn Helgaas wrote:
> My proposal handles endpoints, too.  The pci_walk_bus() in the quirk
> handles all devices we've already enumerated, and all devices we'll
> enumerate in the future are handled in pci_configure_device().

Code clears the endpoint's extended tag capability only if a quirky host
bridge is found. 

The question here was 

"what if you have an endpoint, it may declare extended tags capability
and has a bug even though the host bridge is just fine"

Code will enable extended tags on both the host bridge and endpoint
if it is supported.

The host bridge will start generating 256 tags towards the endpoint
but endpoint is unable to catch up with it. 

Same thing is possible with two endpoints that try to do peer-to-peer
communication. The first endpoint may generate 256 requests, second
endpoint may not handle it.

Again, this is a hypothetical condition with no known endpoints. I
suggest we deal with this when time comes.

Sinan 


-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2017-07-12 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 15:25 [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port Sinan Kaya
2017-07-11 15:25 ` [PATCH V3 2/2] PCI: Do not enable extended tags if a quirky device is found Sinan Kaya
2017-07-11 19:58 ` [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port Bjorn Helgaas
2017-07-11 20:16   ` Sinan Kaya
2017-07-11 20:39     ` Bjorn Helgaas
2017-07-12 13:07       ` Sinan Kaya [this message]
2017-07-12 19:45         ` Bjorn Helgaas
2017-07-12 19:47           ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25b6bbf6-20b5-dfc8-c92a-268c07fa1f98@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=timur@codeaurora.org \
    --cc=wim.ten.have@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).