From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Geert Uytterhoeven , "devicetree@vger.kernel.org" , linaro-kernel , Benjamin Herrenschmidt , linux-pci , Liviu Dudau , LKML , Will Deacon , Tanmay Inamdar , Catalin Marinas , Bjorn Helgaas Subject: Re: [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree Date: Mon, 10 Mar 2014 20:28:32 +0100 Message-ID: <2669340.5Jm6AjVlSo@wuerfel> In-Reply-To: References: <1394020137-1830-1-git-send-email-Liviu.Dudau@arm.com> <1469359.kil5iaOqdU@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: On Monday 10 March 2014 20:16:25 Geert Uytterhoeven wrote: > On Mon, Mar 10, 2014 at 7:59 PM, Arnd Bergmann wrote: > >> arch/avr32/include/asm/io.h:#define IO_SPACE_LIMIT 0xffffffff > >> arch/frv/include/asm/io.h:#define IO_SPACE_LIMIT 0xffffffff > > > > They have no MMU, and the code relies on the port number to match > > both the virtual and the physical address. You could be right about > > these, but I would guess that the code also needs some other > > changes if we want to make it work on nommu kernels. It also depends > > on whether the I/O bus address is the same as the CPU address, or > > if it starts at bus address 0. > > >> arch/m68k/include/asm/io_no.h:#define IO_SPACE_LIMIT 0xffffffff > > > > This looks like a mistake, it should be smaller > > io_no.h is for nommu. Ah, I missed that. In that case I assume it doesn't matter because the only m68k with PCI is M54xx and that always has an MMU. Arnd