From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Andrew Murray <Andrew.Murray@arm.com>,
linux-pci@vger.kernel.org,
"thierry.reding@avionic-design.de"
<thierry.reding@avionic-design.de>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI.
Date: Fri, 12 Apr 2013 13:13:20 +0200 [thread overview]
Message-ID: <2781744.X672n7t2jq@vostro.rjw.lan> (raw)
In-Reply-To: <20130411234426.GA10196@google.com>
On Thursday, April 11, 2013 05:44:26 PM Bjorn Helgaas wrote:
> On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote:
> > Signed-off-by: Andrew Murray <Andrew.Murray@arm.com>
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> > ---
> > drivers/pci/pcie/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> > index 6c8bc58..4cccd8c 100644
> > --- a/drivers/pci/pcie/Kconfig
> > +++ b/drivers/pci/pcie/Kconfig
> > @@ -82,4 +82,4 @@ endchoice
> >
> > config PCIE_PME
> > def_bool y
> > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI
> > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
>
> I think we can go even further and remove the ACPI-related #includes
> as in the patch below. Any objections to this?
>
>
> commit 8bde83b5f5519b630e7630fb735f76c184c74289
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date: Thu Apr 11 17:36:50 2013 -0600
>
> PCI: Remove unnecessary dependencies between PME and ACPI
>
> PCIe PME doesn't depend on ACPI, so remove the #includes and
> Kconfig dependency.
>
> Based-on-patch-by: Andrew Murray <Andrew.Murray@arm.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index fde4a32..569f82f 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -82,4 +82,4 @@ endchoice
>
> config PCIE_PME
> def_bool y
> - depends on PCIEPORTBUS && PM_RUNTIME && ACPI
> + depends on PCIEPORTBUS && PM_RUNTIME
> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
> index 9ca0dc9..795db1f 100644
> --- a/drivers/pci/pcie/pme.c
> +++ b/drivers/pci/pcie/pme.c
> @@ -19,8 +19,6 @@
> #include <linux/interrupt.h>
> #include <linux/device.h>
> #include <linux/pcieport_if.h>
> -#include <linux/acpi.h>
> -#include <linux/pci-acpi.h>
> #include <linux/pm_runtime.h>
>
> #include "../pci.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-04-12 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 15:53 [PATCH] pci: Remove unnecessary dependency between PME and ACPI Andrew Murray
2013-04-11 23:44 ` Bjorn Helgaas
2013-04-12 7:42 ` Andrew Murray
2013-04-12 11:13 ` Rafael J. Wysocki [this message]
2013-04-12 19:03 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2781744.X672n7t2jq@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Andrew.Murray@arm.com \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox