From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org,
linux-sound@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-clk@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro
Date: Mon, 25 Aug 2025 09:48:05 +0200 [thread overview]
Message-ID: <2795210.mvXUDI8C0e@workhorse> (raw)
In-Reply-To: <175340605069.3513.18204498860033427106@lazor>
On Friday, 25 July 2025 03:14:10 Central European Summer Time Stephen Boyd wrote:
> Quoting Nicolas Frattaroli (2025-06-23 09:05:47)
> > The sp7021 clock driver has its own shifted high word mask macro,
> > similar to the ones many Rockchip drivers have.
> >
> > Remove it, and replace instances of it with hw_bitfield.h's
> > FIELD_PREP_WM16 macro, which does the same thing except in a common
> > macro that also does compile-time error checking.
> >
> > This was compile-tested with 32-bit ARM with Clang, no runtime tests
> > were performed as I lack the hardware. However, I verified that fix
> > commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()")
> > is not regressed. No warning is produced.
>
> Does it generate the same code before and after?
>
Yes, the generated machine code is exactly the same, at least with
clang, and I'll assume it'll be the same for gcc.
Kind regards,
Nicolas Frattaroli
next prev parent reply other threads:[~2025-08-25 7:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 16:05 [PATCH v2 00/20] BYEWORD_UPDATE: unifying (most) HIWORD_UPDATE macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 01/20] bitmap: introduce hardware-specific bitfield operations Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 02/20] mmc: dw_mmc-rockchip: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 03/20] soc: rockchip: grf: switch to FIELD_PREP_WM16_CONST macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 04/20] media: synopsys: hdmirx: replace macros with bitfield variants Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 05/20] drm/rockchip: lvds: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 06/20] phy: rockchip-emmc: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 07/20] drm/rockchip: dsi: switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 08/20] drm/rockchip: vop2: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 09/20] phy: rockchip-samsung-dcphy: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 10/20] drm/rockchip: dw_hdmi_qp: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 11/20] drm/rockchip: inno-hdmi: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 12/20] phy: rockchip-usb: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 13/20] drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 14/20] ASoC: rockchip: i2s-tdm: switch to FIELD_PREP_WM16_CONST macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 15/20] net: stmmac: dwmac-rk: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 16/20] PCI: rockchip: Switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 17/20] PCI: dw-rockchip: Switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 18/20] PM / devfreq: rockchip-dfi: switch " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 19/20] clk: sp7021: " Nicolas Frattaroli
2025-07-25 1:14 ` Stephen Boyd
2025-08-25 7:48 ` Nicolas Frattaroli [this message]
2025-09-21 20:04 ` Stephen Boyd
2025-06-23 16:05 ` [PATCH v2 20/20] phy: rockchip-pcie: " Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2795210.mvXUDI8C0e@workhorse \
--to=nicolas.frattaroli@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).