From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FC0EB64DD for ; Thu, 20 Jul 2023 06:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjGTGrX (ORCPT ); Thu, 20 Jul 2023 02:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjGTGrW (ORCPT ); Thu, 20 Jul 2023 02:47:22 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BB3B135; Wed, 19 Jul 2023 23:47:20 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id A08178803; Thu, 20 Jul 2023 14:47:12 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Jul 2023 14:47:12 +0800 Received: from [192.168.125.127] (113.72.147.86) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Jul 2023 14:47:11 +0800 Message-ID: <285bcdc4-832f-c278-7a14-7ccf295aaa09@starfivetech.com> Date: Thu, 20 Jul 2023 14:47:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/9] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Content-Language: en-US To: Rob Herring CC: Daire McNamara , Conor Dooley , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Emil Renner Berthing , , , , , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230719102057.22329-1-minda.chen@starfivetech.com> <20230719102057.22329-2-minda.chen@starfivetech.com> <20230719223124.GB882340-robh@kernel.org> From: Minda Chen In-Reply-To: <20230719223124.GB882340-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.86] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2023/7/20 6:31, Rob Herring wrote: > On Wed, Jul 19, 2023 at 06:20:49PM +0800, Minda Chen wrote: >> Add PLDA XpressRICH PCIe host common properties dt-binding doc. >> Microchip PolarFire PCIe host using PLDA IP. >> Extract properties from Microchip PolarFire PCIe host. >> >> Signed-off-by: Minda Chen >> Reviewed-by: Hal Feng >> --- >> .../pci/plda,xpressrich-pcie-common.yaml | 72 +++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> new file mode 100644 >> index 000000000000..3627a846c5d1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/plda,xpressrich-pcie-common.yaml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/plda,xpressrich-pcie-common.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: PLDA XpressRICH PCIe host common properties >> + >> +maintainers: >> + - Daire McNamara >> + - Minda Chen >> + >> +description: >> + Generic PLDA XpressRICH PCIe host common properties. >> + >> +select: false >> + >> +properties: >> + reg: >> + description: >> + At least host IP register set and configuration space are >> + required for normal controller work. >> + maxItems: 2 >> + >> + reg-names: >> + oneOf: >> + - items: >> + - const: cfg >> + - const: apb >> + - items: >> + - const: host >> + - const: cfg > > This didn't exist before. Where's the reasoning? > > There's no reason for 'cfg' to be in different spots and little reason > to have different names for the host/apb space. > > Rob > ok, I will follow cfg and apb