From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-pci@vger.kernel.org,
"Rick Wertenbroek" <rick.wertenbroek@gmail.com>
Subject: Re: [PATCH v3 6/7] PCI: endpoint: test: Use pci_epc_mem_map/unmap()
Date: Mon, 7 Oct 2024 07:15:06 +0900 [thread overview]
Message-ID: <2899bd11-4a8f-4328-9ece-94b8227093f2@kernel.org> (raw)
In-Reply-To: <ZwJ49NkwhKpeuwKa@ryzen.lan>
On 10/6/24 20:48, Niklas Cassel wrote:
> On Fri, Oct 04, 2024 at 10:47:01PM +0900, Damien Le Moal wrote:
>> On 10/4/24 21:11, Niklas Cassel wrote:
>
> (snip)
>
>>> I think that you need to also include the patch that implements map_align()
>>> for rk3399 in this series (without any other rk3399 patches), such that the
>>> API actually makes sense.
>>
>> This is coming in a followup series. Note that the Cadence controller also look
>> suspiciously similar to the rk3399, so it may need the same treatment.
>
> I strongly think that you should continue to include patch:
> "PCI: rockchip-ep: Implement the map_align endpoint controller operation"
> (that was part of your V2) in this series.
I would rather not because this patch needs a prep patch that fixes the
currently broken rockchip_pcie_prog_ep_ob_atu() function. So I will post this
patch as part of a series for the rk3399 today.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-10-06 22:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 5:07 [PATCH v3 0/7] Improve PCI memory mapping API Damien Le Moal
2024-10-04 5:07 ` [PATCH v3 1/7] PCI: endpoint: Introduce pci_epc_function_is_valid() Damien Le Moal
2024-10-04 5:07 ` [PATCH v3 2/7] PCI: endpoint: Improve pci_epc_mem_alloc_addr() Damien Le Moal
2024-10-04 11:45 ` Niklas Cassel
2024-10-04 5:07 ` [PATCH v3 3/7] PCI: endpoint: Introduce pci_epc_map_align() Damien Le Moal
2024-10-04 11:45 ` Niklas Cassel
2024-10-04 5:07 ` [PATCH v3 4/7] PCI: endpoint: Introduce pci_epc_mem_map()/unmap() Damien Le Moal
2024-10-04 11:47 ` Niklas Cassel
2024-10-04 13:29 ` Damien Le Moal
2024-10-07 2:01 ` kernel test robot
2024-10-04 5:07 ` [PATCH v3 5/7] PCI: endpoint: Update documentation Damien Le Moal
2024-10-04 11:51 ` Niklas Cassel
2024-10-04 5:07 ` [PATCH v3 6/7] PCI: endpoint: test: Use pci_epc_mem_map/unmap() Damien Le Moal
2024-10-04 12:11 ` Niklas Cassel
2024-10-04 13:47 ` Damien Le Moal
2024-10-06 11:48 ` Niklas Cassel
2024-10-06 22:15 ` Damien Le Moal [this message]
2024-10-04 5:07 ` [PATCH v3 7/7] PCI: dwc: endpoint: Define the .map_align() controller operation Damien Le Moal
2024-10-04 12:12 ` Niklas Cassel
2024-10-04 11:45 ` [PATCH v3 0/7] Improve PCI memory mapping API Niklas Cassel
2024-10-04 13:13 ` Niklas Cassel
2024-10-04 13:25 ` Damien Le Moal
2024-10-06 11:46 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2899bd11-4a8f-4328-9ece-94b8227093f2@kernel.org \
--to=dlemoal@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=corbet@lwn.net \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rick.wertenbroek@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).