From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: "Rafael J. Wysocki" To: Kilian Singer Cc: Bjorn Helgaas , Peter Wu , Lukas Wunner , Mika Westerberg , linux-pci , Alex Deucher , Dave Airlie Subject: Re: PCI: Revert "PCI: Add runtime PM support for PCIe ports" Date: Tue, 03 Jan 2017 23:07:31 +0100 Message-ID: <2944797.fnVvnXZV6t@aspire.rjw.lan> In-Reply-To: <3ce9e85d-381c-1c5d-b01d-65b8cf64e1ae@quantumtechnology.info> References: <20161228161816.GA19653@bhelgaas-glaptop.roam.corp.google.com> <3913750.OA6IItgEjC@aspire.rjw.lan> <3ce9e85d-381c-1c5d-b01d-65b8cf64e1ae@quantumtechnology.info> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: On Tuesday, January 03, 2017 10:52:48 PM Kilian Singer wrote: > I have not checked if suspend/resume broken. > Which patch should I check suspend resume for. > When I wrote about firefox and lockscreen issue resolved > I forgot to check about the suspend/resume. Well, here: https://bugzilla.kernel.org/show_bug.cgi?id=190861#c26 you said: "Shutdown and suspend/resume work on 4.7.0-1 but fail on 4.8. and 4.9." and here: https://bugzilla.kernel.org/show_bug.cgi?id=190861#c29 you said: "the pci_port_pm=off fixes both the firefox issue and the lock screen issue. Also suspend/resume work. Tested on 4.9" which to me means that suspend/resume is also broken for you due to the PCIe ports PM support enabled (the command line option should be pcie_port_pm=off, BTW, but I'm assuming that this is what you actually used). Now, it may be broken due to the runtime PM breakage triggering after system resume (which may be verified by checking if the revert actually fixes system suspend-resume too on your machine), but even then I wouldn't revert that particular commit. Thanks, Rafael