From: Vidya Sagar <vidyas@nvidia.com>
To: lpieralisi@kernel.org
Cc: Rob Herring <robh@kernel.org>,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V2] PCI: dwc: Fix n_fts[] array overrun
Date: Mon, 10 Oct 2022 11:21:42 +0530 [thread overview]
Message-ID: <29e9a0ac-3424-51f0-71bd-b67f64dad648@nvidia.com> (raw)
In-Reply-To: <CAL_JsqJ1qLC7zEL=hhgvsdimgcxxkPhN9LCJy3DnYZ8K8LJkLQ@mail.gmail.com>
Hi Lorenzo,
Do you have any further comments for this patch?
Thanks,
Vidya Sagar
On 10/5/2022 3:20 AM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, Sep 26, 2022 at 6:19 AM Vidya Sagar <vidyas@nvidia.com> wrote:
>>
>> commit aeaa0bfe89654 ("PCI: dwc: Move N_FTS setup to common setup")
>> incorrectly uses pci->link_gen in deriving the index to the
>> n_fts[] array also introducing the issue of accessing beyond the
>> boundaries of array for greater than Gen-2 speeds. This change fixes
>> that issue.
>>
>> Fixes: aeaa0bfe8965 ("PCI: dwc: Move N_FTS setup to common setup")
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>> ---
>> V2:
>> * Addressed review comments from Bjorn
>> * Added "Acked-by: Jingoo Han <jingoohan1@gmail.com>"
>>
>> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
next prev parent reply other threads:[~2022-10-10 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 14:31 [PATCH V1] PCI: dwc: Fixes N_FTS setup Vidya Sagar
2022-09-19 17:29 ` Bjorn Helgaas
2022-09-23 20:57 ` Han Jingoo
2022-09-26 11:19 ` [PATCH V2] PCI: dwc: Fix n_fts[] array overrun Vidya Sagar
2022-09-29 2:04 ` Han Jingoo
2022-09-29 4:57 ` Vidya Sagar
2022-09-29 16:49 ` Han Jingoo
2022-10-04 21:50 ` Rob Herring
2022-10-10 5:51 ` Vidya Sagar [this message]
2022-10-27 8:15 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e9a0ac-3424-51f0-71bd-b67f64dad648@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).