From: Logan Gunthorpe <logang@deltatee.com>
To: Krzysztof Wilczynski <kw@linux.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/switchtec: Correct bool variable type assignment
Date: Thu, 21 May 2020 14:06:29 -0600 [thread overview]
Message-ID: <2a4bbda2-fe1d-de2d-7a0c-b2a718e88a25@deltatee.com> (raw)
In-Reply-To: <20200521200439.1076672-1-kw@linux.com>
On 2020-05-21 2:04 p.m., Krzysztof Wilczynski wrote:
> Use true instead of 1 in the assignment as the variable use_dma_mrpc is
> of a bool type. Also, resolve the following Coccinelle warning:
>
> drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Sure,
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> drivers/pci/switch/switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index e69cac84b605..850cfeb74608 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -25,7 +25,7 @@ static int max_devices = 16;
> module_param(max_devices, int, 0644);
> MODULE_PARM_DESC(max_devices, "max number of switchtec device instances");
>
> -static bool use_dma_mrpc = 1;
> +static bool use_dma_mrpc = true;
> module_param(use_dma_mrpc, bool, 0644);
> MODULE_PARM_DESC(use_dma_mrpc,
> "Enable the use of the DMA MRPC feature");
>
next prev parent reply other threads:[~2020-05-21 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 20:04 [PATCH] PCI/switchtec: Correct bool variable type assignment Krzysztof Wilczynski
2020-05-21 20:06 ` Logan Gunthorpe [this message]
2020-05-21 20:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4bbda2-fe1d-de2d-7a0c-b2a718e88a25@deltatee.com \
--to=logang@deltatee.com \
--cc=bhelgaas@google.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox