From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: zhangsenchuan@eswincomputing.com, bhelgaas@google.com,
krzk+dt@kernel.org, conor+dt@kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, robh@kernel.org, p.zabel@pengutronix.de,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, christian.bruel@foss.st.com,
mayank.rana@oss.qualcomm.com, shradha.t@samsung.com,
krishna.chundru@oss.qualcomm.com, thippeswamy.havalige@amd.com,
inochiama@gmail.com, ningyu@eswincomputing.com,
linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com,
ouyanghui@eswincomputing.com
Subject: Re: [PATCH v4 1/2] dt-bindings: PCI: EIC7700: Add Eswin PCIe host controller
Date: Mon, 3 Nov 2025 12:26:46 +0100 [thread overview]
Message-ID: <2b5eb6f3-8e48-4248-bf26-4ebd358217ff@kernel.org> (raw)
In-Reply-To: <urkbwcgmi4n7owlf4pu7hy5aeg4h7pgsecmie7tpfjhl3v64oh@zuuhr3b4wytz>
On 03/11/2025 10:02, Manivannan Sadhasivam wrote:
>>> + interrupt-names:
>>> + items:
>>> + - const: msi
>>> + - const: inta
>>> + - const: intb
>>> + - const: intc
>>> + - const: intd
>>
>> Thse are legacy signals. Why are you using legacy?
>>
>
> Why not? These INTx signals are still supported by many host platforms/devices.
> These are not individual out-of-band signals, but just in-band messages. It is
> perfectly fine for a host controller to support them.
Considering how many other legacy things were used in this binding, I
just have doubts that choice of entries was correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-03 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 8:28 [PATCH v4 0/2] Add driver support for Eswin EIC7700 SoC PCIe controller zhangsenchuan
2025-10-30 8:30 ` [PATCH v4 1/2] dt-bindings: PCI: EIC7700: Add Eswin PCIe host controller zhangsenchuan
2025-11-03 8:48 ` Krzysztof Kozlowski
2025-11-03 9:02 ` Manivannan Sadhasivam
2025-11-03 11:26 ` Krzysztof Kozlowski [this message]
2025-11-10 9:27 ` zhangsenchuan
2025-10-30 8:31 ` [PATCH v4 2/2] PCI: EIC7700: Add Eswin PCIe host controller driver zhangsenchuan
2025-10-30 8:43 ` Philipp Zabel
2025-10-30 23:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b5eb6f3-8e48-4248-bf26-4ebd358217ff@kernel.org \
--to=krzk@kernel.org \
--cc=bhelgaas@google.com \
--cc=christian.bruel@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=inochiama@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mayank.rana@oss.qualcomm.com \
--cc=ningyu@eswincomputing.com \
--cc=ouyanghui@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=thippeswamy.havalige@amd.com \
--cc=zhangsenchuan@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).